[jira] [Commented] (MBUILDCACHE-37) Allow disabled-by-default configuration

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MBUILDCACHE-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676705#comment-17676705 ] 

ASF GitHub Bot commented on MBUILDCACHE-37:
-------------------------------------------

ahus1 opened a new pull request, #37:
URL: https://github.com/apache/maven-build-cache-extension/pull/37

   This allows this plugin to be enabled on the CLI with 
   
   ```
   -Dmaven.build.cache.enabled=true
   ```
   
   when it is disabled by default in the XML.
   
   ---
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [ x Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Allow disabled-by-default configuration
> ---------------------------------------
>
>                 Key: MBUILDCACHE-37
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-37
>             Project: Maven Build Cache Extension
>          Issue Type: Improvement
>          Components: remote build cache
>    Affects Versions: 1.0.0
>            Reporter: Alexander Schwartz
>            Priority: Major
>
> I'm trying to create a configuration where the extension is disabled by default and can be enabled by some key users as a opt-in. 
> My first attempt: 
>  * in the XML, set `cache.configuration.enabled` to `false`
> -> This disables it by default
>  * On the CLI, set `-Dmaven.build.cache.enabled=true`
> -> This was intended to enable it "opt in" - but failed, see below.
> The problem: 
> The code in
> [https://github.com/apache/maven-build-cache-extension/blob/2d262e133749abb5163969b9c0b2f0f2056e7951/src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java#L181-L184]
> will use the "disable" state in the XML. 
> Suggested change: `maven.build.cache.enabled` should override the setting `cache.configuration.enabled` in the XML. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)