You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dhaval Rajpara <dh...@gmail.com> on 2022/12/08 18:17:28 UTC
Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3537
https://issues.apache.org/jira/browse/RANGER-3537
Repository: ranger
Description
-------
As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
The given review request contains code changes for migrating Ranger Admin UI to use React JS.
Created a react-webapp directory inside the existing webapp directory to add the code changes.
To build a Ranger Admin UI with this changes, please use below mvn command :
--> mvn clean compile package -DskipTests -Psecurity-admin-react
Diffs
-----
security-admin/pom.xml f887e03a1
security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
Diff: https://reviews.apache.org/r/74246/diff/1/
Testing
-------
1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
3) Verified Import/exporting of policies.
4) Verified report page search.
5) Verified all the logs under Audit Tab.
Thanks,
Dhaval Rajpara
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Dhaval Rajpara <dh...@gmail.com>.
> On Dec. 13, 2022, 7:53 p.m., Madhan Neethiraj wrote:
> > Dhaval - thank you for the updates. I was able to build and deploy Ranger with react UI in docker container. Here is my feedback:
> >
> > 1. Audit page: timestamp shown in Last Update Time seems to be GMT. This should be the local time of the browser.
> > The same for the default shown for START DATE filter in Access tab. In fact Last Response Time rendered in each page has GMT.
> >
> > 2. Audit page: Plugin Status tab fails with following error:
> > Error: Minified React error #152; visit https://reactjs.org/docs/error-decoder.html?invariant=152&args[]=Cell for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
> > at Cell (http://localhost:6080/dist/914.6554b4bab0013976038d.js:1:7168)
> >
> > 3. Policy UI: the default resource hierarchy shown for Hive is Global. I guess this was Database/Table/Column in current UI. Please review.
> >
> > 4. Policy UI: when a resource is selected (like Database), 'None' should be shown as the child - if the resource is a valid-leaf. Please compare this with the current UI.
> >
> > 5. Policy UI: validity period UI shows dates in dd-mm-yyyy format. Instead, this should be in locale of the browser. For example, for en-us dates should be rendered as mm-dd-yyyy
> >
> > 6. Policy UI: it should be possible to reorder masking policy items, as the mask applied can depend on the order in which the items are listed.
> >
> > 7. Policy UI: it should be possible to reorder row-filter policy items, as the filter applied can depend on the order in which the items are listed.
> >
> > 8. Policy UI: when only one permission is listed, it will help if UI can automatically select the permission. For example, Hive masking/row-filter policies has only 'select' as the permission. In such cases, this should be automatically selected.
> >
> > 9. Policy UI: while entering resource values (in policy UI, zone UI), pressing enter doesn't accept the input immediately. It takes couple of seconds. Perhaps UI is waiting to get response for the resource-lookup call. I don't remember seeing such delay in current UI.
> >
> > 10. Policy UI: option to enter additional resources is missing. This is tracked by RANGER-4010. Adding here for completeness.
Hi Madhan,
Thank you for taking the time to provide us with your more valuable feedback.
1) Audit page: timestamp shown in Last Update Time seems to be GMT. This should be the local time of the browser.
The same for the default shown for START DATE filter in Access tab. In fact Last Response Time rendered in each page has GMT.
--> We have the fix ready in latest Review Request.
2)Audit page: Plugin Status tab fails with following error:
Error: Minified React error #152; visit https://reactjs.org/docs/error-decoder.html?invariant=152&args[]=Cell for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at Cell (http://localhost:6080/dist/914.6554b4bab0013976038d.js:1:7168)
--> We have the fix ready in latest Review Request.
3)Policy UI: the default resource hierarchy shown for Hive is Global. I guess this was Database/Table/Column in current UI. Please review.
--> We have the fix ready in latest Review Request.
4)Policy UI: when a resource is selected (like Database), 'None' should be shown as the child - if the resource is a valid-leaf. Please compare this with the current UI.
--> We have the fix ready in latest Review Request.
5)Policy UI: validity period UI shows dates in dd-mm-yyyy format. Instead, this should be in locale of the browser. For example, for en-us dates should be rendered as mm-dd-yyyy
--> We have the fix ready in latest Review Request.
6)Policy UI: it should be possible to reorder masking policy items, as the mask applied can depend on the order in which the items are listed.
--> Created separate Jira RANGER-4016 to handle this.
7)Policy UI: it should be possible to reorder row-filter policy items, as the filter applied can depend on the order in which the items are listed.
--> Created separate Jira RANGER-4016 to handle this.
8)Policy UI: when only one permission is listed, it will help if UI can automatically select the permission. For example, Hive masking/row-filter policies has only 'select' as the permission. In such cases, this should be automatically selected.
--> This will block policy creation without a policy item so we keep it as same as backbone.js
9)Policy UI: while entering resource values (in policy UI, zone UI), pressing enter doesn't accept the input immediately. It takes couple of seconds. Perhaps UI is waiting to get response for the resource-lookup call. I don't remember seeing such delay in current UI.
--> Yes, this is done explicitly. because in backbone.js whenever the user enters the value resource field make a request for each and every key press. So in this case we add a 2-second debounce function (currently I change this to 1 second to make this a little faster).
- Dhaval
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/#review224998
-----------------------------------------------------------
On Dec. 13, 2022, 2:13 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74246/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2022, 2:13 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3537
> https://issues.apache.org/jira/browse/RANGER-3537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
>
> The given review request contains code changes for migrating Ranger Admin UI to use React JS.
> Created a react-webapp directory inside the existing webapp directory to add the code changes.
>
> To build a Ranger Admin UI with this changes, please use below mvn command :
>
> --> mvn clean compile package -DskipTests -Psecurity-admin-react
>
>
> Diffs
> -----
>
> security-admin/pom.xml f887e03a1
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
> security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
> security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74246/diff/2/
>
>
> Testing
> -------
>
> 1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
> 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
> 3) Verified Import/exporting of policies.
> 4) Verified report page search.
> 5) Verified all the logs under Audit Tab.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/#review224998
-----------------------------------------------------------
Dhaval - thank you for the updates. I was able to build and deploy Ranger with react UI in docker container. Here is my feedback:
1. Audit page: timestamp shown in Last Update Time seems to be GMT. This should be the local time of the browser.
The same for the default shown for START DATE filter in Access tab. In fact Last Response Time rendered in each page has GMT.
2. Audit page: Plugin Status tab fails with following error:
Error: Minified React error #152; visit https://reactjs.org/docs/error-decoder.html?invariant=152&args[]=Cell for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at Cell (http://localhost:6080/dist/914.6554b4bab0013976038d.js:1:7168)
3. Policy UI: the default resource hierarchy shown for Hive is Global. I guess this was Database/Table/Column in current UI. Please review.
4. Policy UI: when a resource is selected (like Database), 'None' should be shown as the child - if the resource is a valid-leaf. Please compare this with the current UI.
5. Policy UI: validity period UI shows dates in dd-mm-yyyy format. Instead, this should be in locale of the browser. For example, for en-us dates should be rendered as mm-dd-yyyy
6. Policy UI: it should be possible to reorder masking policy items, as the mask applied can depend on the order in which the items are listed.
7. Policy UI: it should be possible to reorder row-filter policy items, as the filter applied can depend on the order in which the items are listed.
8. Policy UI: when only one permission is listed, it will help if UI can automatically select the permission. For example, Hive masking/row-filter policies has only 'select' as the permission. In such cases, this should be automatically selected.
9. Policy UI: while entering resource values (in policy UI, zone UI), pressing enter doesn't accept the input immediately. It takes couple of seconds. Perhaps UI is waiting to get response for the resource-lookup call. I don't remember seeing such delay in current UI.
10. Policy UI: option to enter additional resources is missing. This is tracked by RANGER-4010. Adding here for completeness.
- Madhan Neethiraj
On Dec. 13, 2022, 2:13 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74246/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2022, 2:13 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3537
> https://issues.apache.org/jira/browse/RANGER-3537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
>
> The given review request contains code changes for migrating Ranger Admin UI to use React JS.
> Created a react-webapp directory inside the existing webapp directory to add the code changes.
>
> To build a Ranger Admin UI with this changes, please use below mvn command :
>
> --> mvn clean compile package -DskipTests -Psecurity-admin-react
>
>
> Diffs
> -----
>
> security-admin/pom.xml f887e03a1
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
> security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
> security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74246/diff/2/
>
>
> Testing
> -------
>
> 1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
> 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
> 3) Verified Import/exporting of policies.
> 4) Verified report page search.
> 5) Verified all the logs under Audit Tab.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Dhaval Rajpara <dh...@gmail.com>.
> On Dec. 15, 2022, 9:30 p.m., Madhan Neethiraj wrote:
> > Dhaval - the fixes look good. Thank you for the quick turnaround.
> >
> > Can you please look into following issues as well?
> > 1. While trying to create a policy in Atlas service, 'Type Category' is the default resource shown. Following list is shown for values: classification, enum, enity, relationship, struct, businessmetadata. After changing the resource to any other type, Entity Type/Atlas Service/Relationship Type, the same dropdown list is shown for values. This doesn't look correct.
> >
> > 2. List of values for 'Type Category/Type Name' has entries with value _NOT_CLASSIFIED. This doesn't look correct.
>
> Dhaval Rajpara wrote:
> Hi madhan,
>
> Updated the patch with the latest changes that address atlas service policy displaying the wrong default value in "Entity type".
>
> Madhan Neethiraj wrote:
> Dhaval - the fix in Atlas policy UI is good!
>
> Build with security-admin-react profile generates large number of files under security-admin/src/main/webapp/react-webapp/node_modules/. Can these files be generated under target directory?
Hi Madhan,
We have added security-admin/src/main/webapp/react-webapp/node_modules/. to ./gitignore file.
- Dhaval
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/#review225003
-----------------------------------------------------------
On Dec. 21, 2022, 2:07 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74246/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2022, 2:07 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3537
> https://issues.apache.org/jira/browse/RANGER-3537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
>
> The given review request contains code changes for migrating Ranger Admin UI to use React JS.
> Created a react-webapp directory inside the existing webapp directory to add the code changes.
>
> To build a Ranger Admin UI with this changes, please use below mvn command :
>
> --> mvn clean compile package -DskipTests -Psecurity-admin-react
>
>
> Diffs
> -----
>
> security-admin/pom.xml f887e03a1
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
> security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
> security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74246/diff/4/
>
>
> Testing
> -------
>
> 1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
> 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
> 3) Verified Import/exporting of policies.
> 4) Verified report page search.
> 5) Verified all the logs under Audit Tab.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Dhaval Rajpara <dh...@gmail.com>.
> On Dec. 15, 2022, 9:30 p.m., Madhan Neethiraj wrote:
> > Dhaval - the fixes look good. Thank you for the quick turnaround.
> >
> > Can you please look into following issues as well?
> > 1. While trying to create a policy in Atlas service, 'Type Category' is the default resource shown. Following list is shown for values: classification, enum, enity, relationship, struct, businessmetadata. After changing the resource to any other type, Entity Type/Atlas Service/Relationship Type, the same dropdown list is shown for values. This doesn't look correct.
> >
> > 2. List of values for 'Type Category/Type Name' has entries with value _NOT_CLASSIFIED. This doesn't look correct.
Hi madhan,
Updated the patch with the latest changes that address atlas service policy displaying the wrong default value in "Entity type".
- Dhaval
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/#review225003
-----------------------------------------------------------
On Dec. 15, 2022, 1:03 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74246/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2022, 1:03 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3537
> https://issues.apache.org/jira/browse/RANGER-3537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
>
> The given review request contains code changes for migrating Ranger Admin UI to use React JS.
> Created a react-webapp directory inside the existing webapp directory to add the code changes.
>
> To build a Ranger Admin UI with this changes, please use below mvn command :
>
> --> mvn clean compile package -DskipTests -Psecurity-admin-react
>
>
> Diffs
> -----
>
> security-admin/pom.xml f887e03a1
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
> security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
> security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74246/diff/3/
>
>
> Testing
> -------
>
> 1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
> 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
> 3) Verified Import/exporting of policies.
> 4) Verified report page search.
> 5) Verified all the logs under Audit Tab.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Dec. 15, 2022, 9:30 p.m., Madhan Neethiraj wrote:
> > Dhaval - the fixes look good. Thank you for the quick turnaround.
> >
> > Can you please look into following issues as well?
> > 1. While trying to create a policy in Atlas service, 'Type Category' is the default resource shown. Following list is shown for values: classification, enum, enity, relationship, struct, businessmetadata. After changing the resource to any other type, Entity Type/Atlas Service/Relationship Type, the same dropdown list is shown for values. This doesn't look correct.
> >
> > 2. List of values for 'Type Category/Type Name' has entries with value _NOT_CLASSIFIED. This doesn't look correct.
>
> Dhaval Rajpara wrote:
> Hi madhan,
>
> Updated the patch with the latest changes that address atlas service policy displaying the wrong default value in "Entity type".
Dhaval - the fix in Atlas policy UI is good!
Build with security-admin-react profile generates large number of files under security-admin/src/main/webapp/react-webapp/node_modules/. Can these files be generated under target directory?
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/#review225003
-----------------------------------------------------------
On Dec. 21, 2022, 2:07 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74246/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2022, 2:07 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3537
> https://issues.apache.org/jira/browse/RANGER-3537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
>
> The given review request contains code changes for migrating Ranger Admin UI to use React JS.
> Created a react-webapp directory inside the existing webapp directory to add the code changes.
>
> To build a Ranger Admin UI with this changes, please use below mvn command :
>
> --> mvn clean compile package -DskipTests -Psecurity-admin-react
>
>
> Diffs
> -----
>
> security-admin/pom.xml f887e03a1
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
> security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
> security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74246/diff/4/
>
>
> Testing
> -------
>
> 1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
> 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
> 3) Verified Import/exporting of policies.
> 4) Verified report page search.
> 5) Verified all the logs under Audit Tab.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Dec. 15, 2022, 9:30 p.m., Madhan Neethiraj wrote:
> > Dhaval - the fixes look good. Thank you for the quick turnaround.
> >
> > Can you please look into following issues as well?
> > 1. While trying to create a policy in Atlas service, 'Type Category' is the default resource shown. Following list is shown for values: classification, enum, enity, relationship, struct, businessmetadata. After changing the resource to any other type, Entity Type/Atlas Service/Relationship Type, the same dropdown list is shown for values. This doesn't look correct.
> >
> > 2. List of values for 'Type Category/Type Name' has entries with value _NOT_CLASSIFIED. This doesn't look correct.
>
> Dhaval Rajpara wrote:
> Hi madhan,
>
> Updated the patch with the latest changes that address atlas service policy displaying the wrong default value in "Entity type".
>
> Madhan Neethiraj wrote:
> Dhaval - the fix in Atlas policy UI is good!
>
> Build with security-admin-react profile generates large number of files under security-admin/src/main/webapp/react-webapp/node_modules/. Can these files be generated under target directory?
>
> Dhaval Rajpara wrote:
> Hi Madhan,
>
> We have added security-admin/src/main/webapp/react-webapp/node_modules/. to ./gitignore file.
Dhaval - it will help if generated files can be located under target directory, as this directory gets cleaned up with 'mvn clean'.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/#review225003
-----------------------------------------------------------
On Dec. 22, 2022, 11:17 a.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74246/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2022, 11:17 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3537
> https://issues.apache.org/jira/browse/RANGER-3537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
>
> The given review request contains code changes for migrating Ranger Admin UI to use React JS.
> Created a react-webapp directory inside the existing webapp directory to add the code changes.
>
> To build a Ranger Admin UI with this changes, please use below mvn command :
>
> --> mvn clean compile package -DskipTests -Psecurity-admin-react
>
>
> Diffs
> -----
>
> .gitignore 9768b791e
> security-admin/pom.xml f887e03a1
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
> security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
> security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74246/diff/5/
>
>
> Testing
> -------
>
> 1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
> 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
> 3) Verified Import/exporting of policies.
> 4) Verified report page search.
> 5) Verified all the logs under Audit Tab.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/#review225003
-----------------------------------------------------------
Ship it!
Dhaval - the fixes look good. Thank you for the quick turnaround.
Can you please look into following issues as well?
1. While trying to create a policy in Atlas service, 'Type Category' is the default resource shown. Following list is shown for values: classification, enum, enity, relationship, struct, businessmetadata. After changing the resource to any other type, Entity Type/Atlas Service/Relationship Type, the same dropdown list is shown for values. This doesn't look correct.
2. List of values for 'Type Category/Type Name' has entries with value _NOT_CLASSIFIED. This doesn't look correct.
- Madhan Neethiraj
On Dec. 15, 2022, 1:03 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74246/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2022, 1:03 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3537
> https://issues.apache.org/jira/browse/RANGER-3537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
>
> The given review request contains code changes for migrating Ranger Admin UI to use React JS.
> Created a react-webapp directory inside the existing webapp directory to add the code changes.
>
> To build a Ranger Admin UI with this changes, please use below mvn command :
>
> --> mvn clean compile package -DskipTests -Psecurity-admin-react
>
>
> Diffs
> -----
>
> security-admin/pom.xml f887e03a1
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
> security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
> security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74246/diff/3/
>
>
> Testing
> -------
>
> 1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
> 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
> 3) Verified Import/exporting of policies.
> 4) Verified report page search.
> 5) Verified all the logs under Audit Tab.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/#review225029
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Dec. 22, 2022, 11:17 a.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74246/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2022, 11:17 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3537
> https://issues.apache.org/jira/browse/RANGER-3537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
>
> The given review request contains code changes for migrating Ranger Admin UI to use React JS.
> Created a react-webapp directory inside the existing webapp directory to add the code changes.
>
> To build a Ranger Admin UI with this changes, please use below mvn command :
>
> --> mvn clean compile package -DskipTests -Psecurity-admin-react
>
>
> Diffs
> -----
>
> .gitignore 9768b791e
> security-admin/pom.xml f887e03a1
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
> security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
> security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74246/diff/5/
>
>
> Testing
> -------
>
> 1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
> 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
> 3) Verified Import/exporting of policies.
> 4) Verified report page search.
> 5) Verified all the logs under Audit Tab.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/#review225023
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Dec. 22, 2022, 11:17 a.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74246/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2022, 11:17 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3537
> https://issues.apache.org/jira/browse/RANGER-3537
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
>
> The given review request contains code changes for migrating Ranger Admin UI to use React JS.
> Created a react-webapp directory inside the existing webapp directory to add the code changes.
>
> To build a Ranger Admin UI with this changes, please use below mvn command :
>
> --> mvn clean compile package -DskipTests -Psecurity-admin-react
>
>
> Diffs
> -----
>
> .gitignore 9768b791e
> security-admin/pom.xml f887e03a1
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
> security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
> security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74246/diff/5/
>
>
> Testing
> -------
>
> 1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
> 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
> 3) Verified Import/exporting of policies.
> 4) Verified report page search.
> 5) Verified all the logs under Audit Tab.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/
-----------------------------------------------------------
(Updated Dec. 22, 2022, 11:17 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3537
https://issues.apache.org/jira/browse/RANGER-3537
Repository: ranger
Description
-------
As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
The given review request contains code changes for migrating Ranger Admin UI to use React JS.
Created a react-webapp directory inside the existing webapp directory to add the code changes.
To build a Ranger Admin UI with this changes, please use below mvn command :
--> mvn clean compile package -DskipTests -Psecurity-admin-react
Diffs (updated)
-----
.gitignore 9768b791e
security-admin/pom.xml f887e03a1
security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
Diff: https://reviews.apache.org/r/74246/diff/5/
Changes: https://reviews.apache.org/r/74246/diff/4-5/
Testing
-------
1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
3) Verified Import/exporting of policies.
4) Verified report page search.
5) Verified all the logs under Audit Tab.
Thanks,
Dhaval Rajpara
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/
-----------------------------------------------------------
(Updated Dec. 21, 2022, 2:07 p.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3537
https://issues.apache.org/jira/browse/RANGER-3537
Repository: ranger
Description
-------
As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
The given review request contains code changes for migrating Ranger Admin UI to use React JS.
Created a react-webapp directory inside the existing webapp directory to add the code changes.
To build a Ranger Admin UI with this changes, please use below mvn command :
--> mvn clean compile package -DskipTests -Psecurity-admin-react
Diffs (updated)
-----
security-admin/pom.xml f887e03a1
security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
Diff: https://reviews.apache.org/r/74246/diff/4/
Changes: https://reviews.apache.org/r/74246/diff/3-4/
Testing
-------
1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
3) Verified Import/exporting of policies.
4) Verified report page search.
5) Verified all the logs under Audit Tab.
Thanks,
Dhaval Rajpara
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/
-----------------------------------------------------------
(Updated Dec. 15, 2022, 1:03 p.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3537
https://issues.apache.org/jira/browse/RANGER-3537
Repository: ranger
Description
-------
As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
The given review request contains code changes for migrating Ranger Admin UI to use React JS.
Created a react-webapp directory inside the existing webapp directory to add the code changes.
To build a Ranger Admin UI with this changes, please use below mvn command :
--> mvn clean compile package -DskipTests -Psecurity-admin-react
Diffs (updated)
-----
security-admin/pom.xml f887e03a1
security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
Diff: https://reviews.apache.org/r/74246/diff/3/
Changes: https://reviews.apache.org/r/74246/diff/2-3/
Testing
-------
1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
3) Verified Import/exporting of policies.
4) Verified report page search.
5) Verified all the logs under Audit Tab.
Thanks,
Dhaval Rajpara
Re: Review Request 74246: RANGER-3537 : Find a viable replacement of Backbone JS for Ranger UI.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74246/
-----------------------------------------------------------
(Updated Dec. 13, 2022, 2:13 p.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3537
https://issues.apache.org/jira/browse/RANGER-3537
Repository: ranger
Description
-------
As backbone JS is an old library, and its related js library like backbone-form, backbone-pagination, and backbone table has not been updated for the last 6 years. Therefore we need to move to the latest and stable UI framework for Ranger UI. This is critical for security reasons.
The given review request contains code changes for migrating Ranger Admin UI to use React JS.
Created a react-webapp directory inside the existing webapp directory to add the code changes.
To build a Ranger Admin UI with this changes, please use below mvn command :
--> mvn clean compile package -DskipTests -Psecurity-admin-react
Diffs (updated)
-----
security-admin/pom.xml f887e03a1
security-admin/src/main/resources/conf.dist/security-applicationContext.xml 4ee80b98f
security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION
security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/favicon.ico PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/styles/style.css PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/appState.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/utils/history.js PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Header.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx PRE-CREATION
Diff: https://reviews.apache.org/r/74246/diff/2/
Changes: https://reviews.apache.org/r/74246/diff/1-2/
Testing
-------
1) Verified CRUD for service/policy/security zone/user/group/roles/permission.
2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR and KMS_AUDITOR role.
3) Verified Import/exporting of policies.
4) Verified report page search.
5) Verified all the logs under Audit Tab.
Thanks,
Dhaval Rajpara