[GitHub] [hudi] nsivabalan commented on a change in pull request #3802: [HUDI-1500] Support replace commit in DeltaSync with commit metadata preserved

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #3802:
URL: https://github.com/apache/hudi/pull/3802#discussion_r734671583



##########
File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java
##########
@@ -1137,8 +1144,9 @@ public void testHoodieAsyncClusteringJob() throws Exception {
     });
   }
 
-  @Test
-  public void testAsyncClusteringService() throws Exception {
+  @ParameterizedTest
+  @ValueSource(strings = {"true", "false"})
+  public void testAsyncClusteringService(String preserveCommitMetadata) throws Exception {

Review comment:
       preserve commit metadata should be applicable to both async and inline clustering right. I would prefer to test it out w/ inline clustering. already we have had some flakiness around async clustering. so don't wanna stir more. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org