You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by slandelle <gi...@git.apache.org> on 2017/11/30 23:09:13 UTC

[GitHub] thrift pull request #1430: Fix generated maven packaging

GitHub user slandelle opened a pull request:

    https://github.com/apache/thrift/pull/1430

    Fix generated maven packaging

    pom packaging is for empty modules. What you're deploying on maven central is a jar artifact. Your current invalid pom.xml causes build tools such as sbt to not be able to download your library!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/slandelle/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1430
    
----
commit b3bf6b475841d9af95a11c26129048fc55d77742
Author: Stephane Landelle <sl...@gatling.io>
Date:   2017-11-30T23:08:56Z

    Fix generated maven packaging
    
    pom packaging is for empty modules. What you're deploying on maven central is a jar artifact. Your current invalid pom.xml causes build tools such as sbt to not be able to download your library!

----


---

[GitHub] thrift issue #1430: Fix generated maven packaging

Posted by Jens-G <gi...@git.apache.org>.

Github user Jens-G commented on the issue:

    https://github.com/apache/thrift/pull/1430
  
    Hi @slandelle, 
    thank you for the patch!
    
    [If you could also create a ticket for it as well](https://thrift.apache.org/docs/committers/HowToRelease), that would be awesome. 


---

[GitHub] thrift pull request #1430: Fix generated maven packaging

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1430


---