You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucy.apache.org by lo...@apache.org on 2013/02/13 08:36:12 UTC

[lucy-commits] git commit: refs/heads/master - Check modified flag prior to calling ruby_binding.write_boot

Updated Branches:
  refs/heads/master c0d180c47 -> c62326212


Check modified flag prior to calling ruby_binding.write_boot

* Modified write_all_modified to return the appropriate ruby fixnum
  value.
* Updated the runtime/rakefile to check for modified return value prior
 to calling ruby_binding.write_boot.


Project: http://git-wip-us.apache.org/repos/asf/lucy/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy/commit/c6232621
Tree: http://git-wip-us.apache.org/repos/asf/lucy/tree/c6232621
Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/c6232621

Branch: refs/heads/master
Commit: c6232621210fa1881b67c9d65d79752e376b0e39
Parents: c0d180c
Author: Logan Bell <lo...@gmail.com>
Authored: Tue Feb 12 23:32:14 2013 -0800
Committer: Logan Bell <lo...@gmail.com>
Committed: Tue Feb 12 23:32:14 2013 -0800

----------------------------------------------------------------------
 clownfish/compiler/ruby/ext/Clownfish/CFC.c |    5 +----
 clownfish/runtime/ruby/Rakefile             |    8 +++++---
 2 files changed, 6 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy/blob/c6232621/clownfish/compiler/ruby/ext/Clownfish/CFC.c
----------------------------------------------------------------------
diff --git a/clownfish/compiler/ruby/ext/Clownfish/CFC.c b/clownfish/compiler/ruby/ext/Clownfish/CFC.c
index 682e2e5..0619ce4 100644
--- a/clownfish/compiler/ruby/ext/Clownfish/CFC.c
+++ b/clownfish/compiler/ruby/ext/Clownfish/CFC.c
@@ -55,11 +55,8 @@ S_CFC_Binding_Core_Write_All_Modified(int argc, VALUE *argv, VALUE self_rb) {
     CFCBindCore *self;
 
     int modified = argc > 0 && RTEST(argv[0]) ? 1 : 0;
-
     Data_Get_Struct(self_rb, CFCBindCore, self);
-    CFCBindCore_write_all_modified(self, modified);
-
-    return Qnil;
+    return INT2NUM(CFCBindCore_write_all_modified(self, modified));
 }
 
 static void

http://git-wip-us.apache.org/repos/asf/lucy/blob/c6232621/clownfish/runtime/ruby/Rakefile
----------------------------------------------------------------------
diff --git a/clownfish/runtime/ruby/Rakefile b/clownfish/runtime/ruby/Rakefile
index 4869aab..ade30b3 100644
--- a/clownfish/runtime/ruby/Rakefile
+++ b/clownfish/runtime/ruby/Rakefile
@@ -64,7 +64,7 @@ task :build_clownfish => [:build_charmonizer_tests] do
   hierarchy.build
   
   core_binding = Clownfish::CFC::Binding::Core.new(:hierarchy => hierarchy, :header => autogen_header, :footer => '')
-  core_binding.write_all_modified
+  modified = core_binding.write_all_modified
 
   ruby_binding = Clownfish::CFC::Binding::Ruby.new(
     :parcel     => "Clownfish",
@@ -75,8 +75,10 @@ task :build_clownfish => [:build_charmonizer_tests] do
     :footer     => ''
   )
 
-  puts "Building Binding Code"
-  ruby_binding.write_boot
+  if (modified)
+    puts "Building Binding Code"
+    ruby_binding.write_boot
+  end
   Rake::Task['compile'].invoke
 
 end