You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "cadonna (via GitHub)" <gi...@apache.org> on 2025/04/11 15:36:40 UTC
[PR] KAFKA-19124: Follow up on code improvements [kafka]
cadonna opened a new pull request, #19453:
URL: https://github.com/apache/kafka/pull/19453
Improves a variable name and handling of an Optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19124: Follow up on code improvements [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna merged PR #19453:
URL: https://github.com/apache/kafka/pull/19453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19124: Follow up on code improvements [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19453:
URL: https://github.com/apache/kafka/pull/19453#discussion_r2040640744
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -319,7 +314,7 @@ private StreamsRebalanceData streamsRebalanceData() {
}
private StreamsRebalanceListener streamsGroupRebalanceCallbacks() {
Review Comment:
Should `streamsGroupRebalanceCallbacks` be reamed to `StreamsRebalanceListener`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19124: Follow up on code improvements [kafka]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #19453:
URL: https://github.com/apache/kafka/pull/19453#discussion_r2048207911
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -319,7 +314,7 @@ private StreamsRebalanceData streamsRebalanceData() {
}
private StreamsRebalanceListener streamsGroupRebalanceCallbacks() {
Review Comment:
@chia7712 the first letter may need to be lower case: `streamsRebalanceListener`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19124: Follow up on code improvements [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19453:
URL: https://github.com/apache/kafka/pull/19453#discussion_r2048208747
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -319,7 +314,7 @@ private StreamsRebalanceData streamsRebalanceData() {
}
private StreamsRebalanceListener streamsGroupRebalanceCallbacks() {
Review Comment:
> the first letter may need to be lower case:
yes - please ignore my typo :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19124: Follow up on code improvements [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on code in PR #19453:
URL: https://github.com/apache/kafka/pull/19453#discussion_r2055585165
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -319,7 +314,7 @@ private StreamsRebalanceData streamsRebalanceData() {
}
private StreamsRebalanceListener streamsGroupRebalanceCallbacks() {
Review Comment:
Thanks for finding this!
Fixed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org