You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/09/03 19:20:51 UTC
[GitHub] [geode] ezoerner opened a new pull request #6841: GEODE:9577: Make PSETEX and SETEX supported commands
ezoerner opened a new pull request #6841:
URL: https://github.com/apache/geode/pull/6841
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] ezoerner commented on a change in pull request #6841: GEODE:9577: Make PSETEX and SETEX supported commands
Posted by GitBox <gi...@apache.org>.
ezoerner commented on a change in pull request #6841:
URL: https://github.com/apache/geode/pull/6841#discussion_r705484796
##########
File path: geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/AbstractSetEXIntegrationTest.java
##########
@@ -55,13 +55,6 @@ public void errors_givenWrongNumberOfArguments() {
assertExactNumberOfArgs(jedis, Protocol.Command.SETEX, 3);
}
- @Test
- public void givenMoreThanFourArgumentsProvided_returnsWrongNumberOfArgumentsError() {
- assertThatThrownBy(
- () -> jedis.sendCommand("key", Protocol.Command.SETEX, "key", "10", "value", "extraArg"))
- .hasMessageContaining("ERR wrong number of arguments for 'setex' command");
- }
-
Review comment:
Sorry, did a force push after @DonalEvans' comment and lost his comment. Next time will add a commit instead of rebasing. He pointed out that this test method is redundant as the assertExactNumberOfArgs in the other test already covers this case. This was a test method that was already present in AbstractSetExIntegrationTest, so removed it. I also had copied this test into AbstractPSetExIntegrationTest, but removed it after Donal's comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans merged pull request #6841: GEODE-9577: Make PSETEX and SETEX supported commands
Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #6841:
URL: https://github.com/apache/geode/pull/6841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] ezoerner commented on a change in pull request #6841: GEODE:9577: Make PSETEX and SETEX supported commands
Posted by GitBox <gi...@apache.org>.
ezoerner commented on a change in pull request #6841:
URL: https://github.com/apache/geode/pull/6841#discussion_r705484796
##########
File path: geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/AbstractSetEXIntegrationTest.java
##########
@@ -55,13 +55,6 @@ public void errors_givenWrongNumberOfArguments() {
assertExactNumberOfArgs(jedis, Protocol.Command.SETEX, 3);
}
- @Test
- public void givenMoreThanFourArgumentsProvided_returnsWrongNumberOfArgumentsError() {
- assertThatThrownBy(
- () -> jedis.sendCommand("key", Protocol.Command.SETEX, "key", "10", "value", "extraArg"))
- .hasMessageContaining("ERR wrong number of arguments for 'setex' command");
- }
-
Review comment:
Sorry, did a force push after @DonalEvans' comment and lost his comment. Next time will add a commit instead of rebasing. He pointed out that this test method is redundant as the `assertExactNumberOfArgs` in the other test already covers this case. This was a test method that was already present in `AbstractSetExIntegrationTest`, so removed it. I also had copied this test into `AbstractPSetExIntegrationTest`, but removed it after Donal's comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on a change in pull request #6841: GEODE:9577: Make PSETEX and SETEX supported commands
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on a change in pull request #6841:
URL: https://github.com/apache/geode/pull/6841#discussion_r704614431
##########
File path: geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/AbstractPSetEXIntegrationTest.java
##########
@@ -55,4 +56,17 @@ public void testPSetEX() {
assertThat(jedis.pttl("key")).isGreaterThanOrEqualTo(1500);
}
+
+ @Test
+ public void givenMoreThanFourArgumentsProvided_returnsWrongNumberOfArgumentsError() {
Review comment:
This case is covered already by the `errors_givenWrongNumberOfArguments()` test, which uses the `assertExactNumberOfArgs()` method to verify that any number of arguments other than the expected (either too many or too few) results in a "ERR wrong number of arguments" message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org