[jira] [Commented] (LUCENE-8057) Bounds not properly computed for exact circles

["Karl Wright (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262585#comment-16262585 ] 

Karl Wright commented on LUCENE-8057:
-------------------------------------

[~ivera], a test case really helps determine what is going on.

The bounds computation for exact circles looks correct:

{code}
    // Add bounds for all circle planes
    for (final SidedPlane plane : circlePlanes) {
      bounds.addPlane(planetModel, plane, eitherBounds.get(plane));
      // We don't bother to compute the intersection bounds since, unless the planet model is pathological, we expect planes to be intersecting at shallow
      // angles.
    }
{code}

I need an example where the bounds for the exact circle is wrong.


> Bounds not properly computed for exact circles
> ----------------------------------------------
>
>                 Key: LUCENE-8057
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8057
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>
> Hi [~daddywri],
> I still get some errors in the tests but luckily it is not related with the last change. The errors always happen between complex polygons and exact circles. I look into it and the problem is that complex polygons require that shapes compute the correct bounds to compute intersections. This is not the case for exact circles.
> It seems a generic bug so I am not attaching a test case. But if you want I can try to work up something.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org