You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/23 15:36:57 UTC

[GitHub] [airflow] nixjdm edited a comment on issue #12563: KubernetesExecutor: Permission Error: User for security context changed, highlighting odd code choice to run at every pod start.

nixjdm edited a comment on issue #12563:
URL: https://github.com/apache/airflow/issues/12563#issuecomment-732236556


   There's two noteworthy parts of this to me.
   
   1. This user 50000 is coming from https://github.com/apache/airflow/blob/6416d898060706787861ff8ecbc4363152a35f45/tests/test_local_settings/test_local_settings.py#L76. Given that file path, I would not expect this code to run unless we're actually running a test. Or is `50000` set somewhere else that's relevant? Grepping, this seems like that's the only place relevant to users/groups. This seems fixed (or at least different) in master at least.
   2. It seems that airflow ensures the creation of the test config file https://github.com/apache/airflow/blob/master/airflow/configuration.py#L776-L781 IMO, if it's possible to move this to code that is run only when running a test, then it should live there. If I never run a test, I wouldn't think I need a test config. This ticket seems like a side-effect of that choice. This bit is in master, too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org