You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jeff Campbell (JIRA)" <ji...@codehaus.org> on 2007/05/31 08:15:58 UTC
[jira] Created: (MPMD-56) targetJdk support for jdk 1.6
targetJdk support for jdk 1.6
-----------------------------
Key: MPMD-56
URL: http://jira.codehaus.org/browse/MPMD-56
Project: Maven 2.x PMD Plugin
Issue Type: Bug
Components: PMD
Affects Versions: 2.2
Environment: Any
Reporter: Jeff Campbell
Currently you can only set a targetJdk to 1.3, 1.4, and 1.5.... what about 1.6?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPMD-56) targetJdk support for jdk 1.6
Posted by "Martin Gilday (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPMD-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_100339 ]
Martin Gilday commented on MPMD-56:
-----------------------------------
I have attached two patches. The first simply adds in 1.6 into the selection statement. The second I think is a slight improvement as it uses SourceType.getSourceTypeForId from PMD to select based upon an id. This should protect from having to change the plugin to eventually support 1.7 (Of course a new release would still be needed to use the new version of PMD).
> targetJdk support for jdk 1.6
> -----------------------------
>
> Key: MPMD-56
> URL: http://jira.codehaus.org/browse/MPMD-56
> Project: Maven 2.x PMD Plugin
> Issue Type: Bug
> Components: PMD
> Affects Versions: 2.2
> Environment: Any
> Reporter: Jeff Campbell
> Attachments: martingilday-pmd-patch.txt, martingilday-pmd-patch2.txt
>
>
> Currently you can only set a targetJdk to 1.3, 1.4, and 1.5.... what about 1.6?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MPMD-56) targetJdk support for jdk 1.6
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPMD-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp closed MPMD-56.
---------------------------
Assignee: Daniel Kulp
Resolution: Fixed
Fix Version/s: 2.3
Patch applied, thanks!
> targetJdk support for jdk 1.6
> -----------------------------
>
> Key: MPMD-56
> URL: http://jira.codehaus.org/browse/MPMD-56
> Project: Maven 2.x PMD Plugin
> Issue Type: Bug
> Components: PMD
> Affects Versions: 2.2
> Environment: Any
> Reporter: Jeff Campbell
> Assignee: Daniel Kulp
> Fix For: 2.3
>
> Attachments: martingilday-pmd-patch.txt, martingilday-pmd-patch2.txt, MPMD_56_targetJdkPatch.txt
>
>
> Currently you can only set a targetJdk to 1.3, 1.4, and 1.5.... what about 1.6?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MPMD-56) targetJdk support for jdk 1.6
Posted by "Martin Gilday (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPMD-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Gilday updated MPMD-56:
------------------------------
Attachment: martingilday-pmd-patch.txt
> targetJdk support for jdk 1.6
> -----------------------------
>
> Key: MPMD-56
> URL: http://jira.codehaus.org/browse/MPMD-56
> Project: Maven 2.x PMD Plugin
> Issue Type: Bug
> Components: PMD
> Affects Versions: 2.2
> Environment: Any
> Reporter: Jeff Campbell
> Attachments: martingilday-pmd-patch.txt
>
>
> Currently you can only set a targetJdk to 1.3, 1.4, and 1.5.... what about 1.6?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MPMD-56) targetJdk support for jdk 1.6
Posted by "Xavier Le Vourch (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPMD-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier Le Vourch updated MPMD-56:
---------------------------------
Attachment: MPMD_56_targetJdkPatch.txt
I've modified the second patch to detect invalid jdk values (i.e. values that the PMD core don't recognize) and raise an error.
The patch also contains a new test case for an invalid jdk value.
Xavier
> targetJdk support for jdk 1.6
> -----------------------------
>
> Key: MPMD-56
> URL: http://jira.codehaus.org/browse/MPMD-56
> Project: Maven 2.x PMD Plugin
> Issue Type: Bug
> Components: PMD
> Affects Versions: 2.2
> Environment: Any
> Reporter: Jeff Campbell
> Attachments: martingilday-pmd-patch.txt, martingilday-pmd-patch2.txt, MPMD_56_targetJdkPatch.txt
>
>
> Currently you can only set a targetJdk to 1.3, 1.4, and 1.5.... what about 1.6?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MPMD-56) targetJdk support for jdk 1.6
Posted by "Martin Gilday (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPMD-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Gilday updated MPMD-56:
------------------------------
Attachment: martingilday-pmd-patch2.txt
> targetJdk support for jdk 1.6
> -----------------------------
>
> Key: MPMD-56
> URL: http://jira.codehaus.org/browse/MPMD-56
> Project: Maven 2.x PMD Plugin
> Issue Type: Bug
> Components: PMD
> Affects Versions: 2.2
> Environment: Any
> Reporter: Jeff Campbell
> Attachments: martingilday-pmd-patch.txt, martingilday-pmd-patch2.txt
>
>
> Currently you can only set a targetJdk to 1.3, 1.4, and 1.5.... what about 1.6?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira