[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

[GitBox <gi...@apache.org>]

ibessonov commented on code in PR #1479:
URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1073489228


##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/TableRow.java:
##########
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.schema;
+
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+
+/** Heap byte buffer-based row. */
+public class TableRow {
+    public static final ByteOrder ORDER = ByteOrder.LITTLE_ENDIAN;
+
+    /** Size of schema version length field. */
+    private static final int SCHEMA_VERSION_FLD_LEN = Short.BYTES;
+
+    /** Row schema version field offset. */
+    private static final int SCHEMA_VERSION_OFFSET = 0;
+
+    /** Row binary tuple field offset. */
+    private static final int TUPLE_OFFSET = SCHEMA_VERSION_OFFSET + SCHEMA_VERSION_FLD_LEN;
+
+    /** Row buffer. */
+    private final ByteBuffer buf;
+
+    /**
+     * Constructor.
+     *
+     * @param data Array representation of the row.
+     */
+    public TableRow(byte[] data) {
+        this(ByteBuffer.wrap(data).order(ORDER));
+    }
+
+    /**
+     * Constructor.
+     *
+     * @param buf Buffer representing the row.
+     */
+    public TableRow(ByteBuffer buf) {
+        assert buf.order() == ORDER;
+        assert buf.position() == 0;
+
+        this.buf = buf;
+    }
+
+    /**
+     * Factory method which creates an instance using a schema version and an existing {@link BinaryTuple}.
+     *
+     * @param schemaVersion Schema version.
+     * @param binaryTuple Binary tuple.
+     * @return Created TableRow instance.
+     */
+    public static TableRow createFromTuple(int schemaVersion, BinaryTuple binaryTuple) {

Review Comment:
   What is the reason of encoding schema version directly into the binary payload? This leads to too much memory manipulation. Storages can do that more efficiently.
   I suggest storing version it as an integer field, and only assemble a byte[] when asked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org