[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3979: note: Move up_schednote.c to drivers/note folder

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on pull request #3979:
URL: https://github.com/apache/incubator-nuttx/pull/3979#issuecomment-870586642


   > Hi @xiaoxiang781216 what happened to SCHED_INSTRUMENTATION_BUFFER?
   
   It's removed from https://github.com/apache/incubator-nuttx/pull/1520
   
   > So, as it has now been removed, the idea of having Instrumentation data saved internally in the memory buffer is not supported? 
   
   Yes, it support and enable by default. Here is the code to serialize the data:
   https://github.com/apache/incubator-nuttx/blob/master/sched/sched/sched_note.c
   Here is the default transport layer which save the node into the ram buffer:
   https://github.com/apache/incubator-nuttx/blob/master/drivers/note/noteram_driver.c
   You can add a new transport as needed.
   
   > I think it is important someone who submitted the driver also take a look. I know @patacongo and someone from sony worked on it. @masayuki2009 do you know who from Sony has worked on this instrumentation support? It is important if he could test again to confirm that nothing was broken.
   
   This patch doesn't change the core of sched note, just make the demo driver more general and test another option(SCHED_INSTRUMENTATION_EXTERNAL).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org