You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "HwangRock (via GitHub)" <gi...@apache.org> on 2026/10/05 14:13:18 UTC

[PR] [ZEPPELIN-5758] Raise BigQuery HTTP client timeout so large wait_time values work [zeppelin]

HwangRock opened a new pull request, #5545:
URL: https://github.com/apache/zeppelin/pull/5545

   ### What is this PR for?
   `zeppelin.bigquery.wait_time` is passed to BigQuery's `jobs.query` as the server-side `timeoutMs`, telling the server how long to wait for the query result before replying. The HTTP client (`NetHttpTransport`), however, kept its default read timeout (~20s). As a result, setting `wait_time` beyond that threshold threw `java.net.SocketTimeoutException: Read timed out` before the server responded, making the setting unusable above ~30s.
   
   This wraps the Bigquery client credential in an `HttpRequestInitializer` that sets the connect/read timeouts to 200s. BigQuery's `getQueryResults` always returns within ~200s regardless of whether the job has completed, so a larger timeout provides no value. The credential's own `initialize()` is still invoked first, so OAuth token refresh behavior is preserved.
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [x] - Wrap the client credential with connect/read timeouts
   * [x] - Add a unit test
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-5758
   
   ### How should this be tested?
   * `./mvnw test -pl bigquery --am -Dtest=BigQueryInterpreterTimeoutTest`
   * `BigQueryInterpreterTimeoutTest` verifies the initializer delegates to the wrapped credential and applies the 200s connect/read timeouts. It is a separate class because `BigQueryInterpreterTest` is excluded from the build (it needs live BigQuery credentials).
   
   ### Questions:
   * Does the license files need to be updated? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-5758] Raise BigQuery HTTP client timeout so large wait_time values work [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5545:
URL: https://github.com/apache/zeppelin/pull/5545


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-5758] Raise BigQuery HTTP client timeout so large wait_time values work [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5545:
URL: https://github.com/apache/zeppelin/pull/5545#issuecomment-6246611421

   Merged into master (2f16789d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org