You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2011/10/21 04:21:02 UTC
Re: svn commit: r1187145 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
On Fri, Oct 21, 2011 at 3:37 AM, <iv...@apache.org> wrote:
> Author: ivaynberg
> Date: Fri Oct 21 00:37:55 2011
> New Revision: 1187145
>
> URL: http://svn.apache.org/viewvc?rev=1187145&view=rev
> Log:
>
> Issue: WICKET-4144
>
> Modified:
> wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
>
> Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
> URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java?rev=1187145&r1=1187144&r2=1187145&view=diff
> ==============================================================================
> --- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java (original)
> +++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java Fri Oct 21 00:37:55 2011
> @@ -68,8 +68,8 @@ public class FilterForm<T> extends Form<
> String id = Strings.escapeMarkup(getFocusTrackerFieldCssId()).toString();
> String value = getRequest().getPostParameters().getParameterValue(id).toString("");
> getResponse().write(
> - String.format("<input type=\"hidden\" name=\"%s\" id=\"%s\" value=\"%s\"/>", id, id,
> - value));
> + String.format("<div><input type=\"hidden\" name=\"%s\" id=\"%s\" value=\"%s\"/></div>",
> + id, id, value));
maybe we should add style="display: inline" to the new div ? otherwise
someone's layout may break now with this new block element
> }
>
> /**
>
>
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
Re: svn commit: r1187145 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
Posted by Adam Gray <ad...@gmail.com>.
Every time someone makes a <div> display: inline, God kills a kitten. 8 \
On Thu, Oct 20, 2011 at 10:21 PM, Martin Grigorov <mg...@apache.org>wrote:
> On Fri, Oct 21, 2011 at 3:37 AM, <iv...@apache.org> wrote:
> > Author: ivaynberg
> > Date: Fri Oct 21 00:37:55 2011
> > New Revision: 1187145
> >
> > URL: http://svn.apache.org/viewvc?rev=1187145&view=rev
> > Log:
> >
> > Issue: WICKET-4144
> >
> > Modified:
> >
> wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
> >
> > Modified:
> wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
> > URL:
> http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java?rev=1187145&r1=1187144&r2=1187145&view=diff
> >
> ==============================================================================
> > ---
> wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
> (original)
> > +++
> wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterForm.java
> Fri Oct 21 00:37:55 2011
> > @@ -68,8 +68,8 @@ public class FilterForm<T> extends Form<
> > String id =
> Strings.escapeMarkup(getFocusTrackerFieldCssId()).toString();
> > String value =
> getRequest().getPostParameters().getParameterValue(id).toString("");
> > getResponse().write(
> > - String.format("<input type=\"hidden\" name=\"%s\"
> id=\"%s\" value=\"%s\"/>", id, id,
> > - value));
> > + String.format("<div><input type=\"hidden\"
> name=\"%s\" id=\"%s\" value=\"%s\"/></div>",
> > + id, id, value));
> maybe we should add style="display: inline" to the new div ? otherwise
> someone's layout may break now with this new block element
> > }
> >
> > /**
> >
> >
> >
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
>