You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "james-willis (via GitHub)" <gi...@apache.org> on 2026/08/12 20:24:23 UTC

[PR] feat(rust/sedona-raster): trinary Override for BandOverrides; copy_into stops composing views [sedona-db]

james-willis opened a new pull request, #1158:
URL: https://github.com/apache/sedona-db/pull/1158

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(rust/sedona-raster): trinary Override for BandOverrides; copy_into stops composing views [sedona-db]

Posted by "james-willis (via GitHub)" <gi...@apache.org>.
james-willis commented on PR #1158:
URL: https://github.com/apache/sedona-db/pull/1158#issuecomment-5481326007

   I don't think that makes sense. The purpose of this PR is to clean up the internal mechanism for raster -> raster functions.
   
   name, uri, format, and view are all fields where callers benefit from being able to use trinary operators to alter the new raster from the existing raster.
   
   The implicity composing of views was a bad ux choice that can now be effectively fixed by the trinary operator so it makes sense to bundle it in here.
   
   There's no benefit anyway to breaking these changes out into many PRs, so why create more developer churn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(rust/sedona-raster): trinary Override for BandOverrides; copy_into stops composing views [sedona-db]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #1158:
URL: https://github.com/apache/sedona-db/pull/1158#issuecomment-5512801361

   > I think its intuititve, round trips properly, and matches PostGis
   
   Are there other functions that have this property (NULL is not propagated as a row level NULL to the output) or is this the only one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(rust/sedona-raster): trinary Override for BandOverrides; copy_into stops composing views [sedona-db]

Posted by "james-willis (via GitHub)" <gi...@apache.org>.
james-willis merged PR #1158:
URL: https://github.com/apache/sedona-db/pull/1158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(rust/sedona-raster): trinary Override for BandOverrides; copy_into stops composing views [sedona-db]

Posted by "james-willis (via GitHub)" <gi...@apache.org>.
james-willis commented on PR #1158:
URL: https://github.com/apache/sedona-db/pull/1158#issuecomment-5512884385

   im not sure about in DF/sedonadb but in a lot of sql engines (e.g. duckdb, spark) you can update the values of a field in a struct to NULL. Duckdb example:
   
   ```sql
   SELECT struct_update(user_profile, age := NULL) AS updated_profile 
   FROM my_table;
   ```
   
   I'm not sure what RS_SetSRID would do.
   
   In Sedona Spark, its _supposed_ (ie documented) to work this way but the function harness intercepts before we get to the function implementation and we return a null raster instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(rust/sedona-raster): trinary Override for BandOverrides; copy_into stops composing views [sedona-db]

Posted by "james-willis (via GitHub)" <gi...@apache.org>.
james-willis commented on PR #1158:
URL: https://github.com/apache/sedona-db/pull/1158#issuecomment-5512766891

   Null -> unset No Data Value iswhat I intended. I think its intuititve, round trips properly, and matches PostGis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(rust/sedona-raster): trinary Override for BandOverrides; copy_into stops composing views [sedona-db]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #1158:
URL: https://github.com/apache/sedona-db/pull/1158#issuecomment-5466808654

   I think it makes sense to use a trinary representation for nodata, or an equivalent dedicated mechanism. However, converting name, outdb_uri, outdb_format, and view at the same time, and changing copy_into from visible-coordinate composition to raw-source replacement is not required for that fix.
   
   Can we scope this PR down to trinary nodata handling?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org