[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14004#discussion_r69305302
  
    --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -801,6 +804,49 @@ public static UTF8String concatWs(UTF8String separator, UTF8String... inputs) {
         return res;
       }
     
    +  /**
    +   * Return a locale of the given language and country, or a default locale when failures occur.
    +   */
    +  private Locale getLocale(UTF8String language, UTF8String country) {
    +    try {
    +      return new Locale(language.toString(), country.toString());
    +    } finally {
    +      return Locale.getDefault();
    +    }
    +  }
    +
    +  /**
    +   * Splits a string into arrays of sentences, where each sentence is an array of words.
    +   */
    +  public ArrayList<ArrayList<UTF8String>> sentences(UTF8String language, UTF8String country) {
    --- End diff --
    
    This method is implemented by String not UTF8String, I think we should put it into another util object(maybe in scala) and takes String as arguments. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org