[jira] [Commented] (ARROW-13873) [C++] Duplicate functions array_filter/array_take and filter/take

["Joris Van den Bossche (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-13873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415555#comment-17415555 ] 

Joris Van den Bossche commented on ARROW-13873:
-----------------------------------------------

Specifically for the sort one: {{ArraySortOptions}} allows a nicer interface to specify the sort order, as you don't need to specify a "dummy" key as with {{SortOptions}} ({{pc.array_sort_indices(arr, order="ascending")}} vs {{pc.sort_indices(arr, sort_keys=[("dummy", "ascending")])}}.

(I don't know if that's worth enough to keep the separate kernel, though)



> [C++] Duplicate functions array_filter/array_take and filter/take
> -----------------------------------------------------------------
>
>                 Key: ARROW-13873
>                 URL: https://issues.apache.org/jira/browse/ARROW-13873
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Weston Pace
>            Priority: Major
>
> This has been explained to me as a metafunction and a backend but in that case the backend should not be registered with the function registry.  Note both:
> {code:cpp}
> const FunctionDoc filter_doc(
>     "Filter with a boolean selection filter",
>     ("The output is populated with values from the input at positions\n"
>      "where the selection filter is non-zero.  Nulls in the selection filter\n"
>      "are handled based on FilterOptions."),
>     {"input", "selection_filter"}, "FilterOptions");
> {code}
> and
> {code:cpp}
> const FunctionDoc array_filter_doc(
>     "Filter with a boolean selection filter",
>     ("The output is populated with values from the input `array` at positions\n"
>      "where the selection filter is non-zero.  Nulls in the selection filter\n"
>      "are handled based on FilterOptions."),
>     {"array", "selection_filter"}, "FilterOptions");
> {code}
> which seems wrong as well.
> Also sort_indices / array_sort_indices



--
This message was sent by Atlassian Jira
(v8.3.4#803005)