You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/02 13:58:55 UTC

[GitHub] [airflow] ephraimbuddy opened a new pull request #10962: Fix doc preview error in editor for google operators doc

ephraimbuddy opened a new pull request #10962:
URL: https://github.com/apache/airflow/pull/10962


   When I open the documentation for google operators in my editor, I receive an error instead of a preview. 
   Here's the error:
   ```
   No preview available.
   
   
   Error output:
   :34: (SEVERE/4) Problems with "include" directive path: InputError: [Errno 2] No such file or directory: '/howto/operator/google/_partials/prerequisite_tasks.rst'. Exiting due to level-4 (SEVERE) system message.
   ```
   This PR addresses it.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10962:
URL: https://github.com/apache/airflow/pull/10962


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ryw commented on pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ryw commented on pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#issuecomment-736995415


   @ephraimbuddy what's next step on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#issuecomment-737666019


   @ryw, I think we're good. All the tests have passed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#issuecomment-696309560


   @turbaszek @mik-laj can you verify if this affects preview on your editor? Thanks😊


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ryw commented on pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ryw commented on pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#issuecomment-737223743


   @ephraimbuddy was issue resolved elsewhere?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#discussion_r536999969



##########
File path: docs/howto/operator/google/transfer/sheets_to_gcs.rst
##########
@@ -32,7 +32,7 @@ common spreadsheet tasks.
 Prerequisite Tasks
 ^^^^^^^^^^^^^^^^^^
 
-.. include:: /howto/operator/google/_partials/prerequisite_tasks.rst
+.. include::/howto/operator/google/_partials/prerequisite_tasks.rst

Review comment:
       I think this turns it in to a comment.
   
   Oh, maybe not?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#issuecomment-737246545


   No, It has not been resolved. I closed it because of @kaxil's first comment, didn't see the next comment. Now, I will reopen it and rebase to fix conflict


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#discussion_r513372330



##########
File path: docs/howto/operator/google/transfer/sheets_to_gcs.rst
##########
@@ -32,7 +32,7 @@ common spreadsheet tasks.
 Prerequisite Tasks
 ^^^^^^^^^^^^^^^^^^
 
-.. include:: /howto/operator/google/_partials/prerequisite_tasks.rst
+.. include::/howto/operator/google/_partials/prerequisite_tasks.rst

Review comment:
       All the directives in Sphinx have a space between them so not sure




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#discussion_r513371476



##########
File path: docs/howto/operator/google/transfer/sheets_to_gcs.rst
##########
@@ -32,7 +32,7 @@ common spreadsheet tasks.
 Prerequisite Tasks
 ^^^^^^^^^^^^^^^^^^
 
-.. include:: /howto/operator/google/_partials/prerequisite_tasks.rst
+.. include::/howto/operator/google/_partials/prerequisite_tasks.rst

Review comment:
       This might not work with Sphinx




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#issuecomment-737019603


   Sorry, I have to close it.
   Thanks @ryw 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy closed pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #10962:
URL: https://github.com/apache/airflow/pull/10962


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#issuecomment-693486735


   Hi, @mik-laj, please can you take a look? Just minor changes(removed spaces) that will help pycharm display doc preview 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#issuecomment-696309560


   @turbaszek @mik-laj can you verify if this affects preview on your editor? Thanks😊


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #10962: Fix doc preview error in editor for google operators doc

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #10962:
URL: https://github.com/apache/airflow/pull/10962#discussion_r536999969



##########
File path: docs/howto/operator/google/transfer/sheets_to_gcs.rst
##########
@@ -32,7 +32,7 @@ common spreadsheet tasks.
 Prerequisite Tasks
 ^^^^^^^^^^^^^^^^^^
 
-.. include:: /howto/operator/google/_partials/prerequisite_tasks.rst
+.. include::/howto/operator/google/_partials/prerequisite_tasks.rst

Review comment:
       I think this turns it in to a comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org