You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hbase.apache.org by nk...@apache.org on 2014/01/21 15:08:32 UTC

svn commit: r1560018 - /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java

Author: nkeywal
Date: Tue Jan 21 14:08:32 2014
New Revision: 1560018

URL: http://svn.apache.org/r1560018
Log:
HBASE-10087 Store should be locked during a memstore snapshot

Modified:
    hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java

Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java?rev=1560018&r1=1560017&r2=1560018&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java Tue Jan 21 14:08:32 2014
@@ -1921,6 +1921,10 @@ public class HStore implements Store {
       this.cacheFlushSeqNum = cacheFlushSeqNum;
     }
 
+    /**
+     * This is not thread safe. The caller should have a lock on the region or the store.
+     * If necessary, the lock can be added with the patch provided in HBASE-10087
+     */
     @Override
     public void prepare() {
       memstore.snapshot();