You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/04/05 20:14:02 UTC
[GitHub] SailingSteve opened a new pull request #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth
SailingSteve opened a new pull request #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/263
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Allows oAuth redirects that return to Android with custom schemes like "twitter://code=nnn" to be
acted on by the InAppBrowser. This is needed for oAuth 2.0 flow.
Here is my actual working JavaScript app code from [https://github.com/WeVote/WebApp/blob/develop/src/js/components/Twitter/TwitterSignIn.jsx](https://github.com/WeVote/WebApp/blob/develop/src/js/components/Twitter/TwitterSignIn.jsx)
```
inAppBrowserRef.addEventListener('customscheme', function (event) {
oAuthLog("customscheme: ", event.url);
TwitterSignIn.handleTwitterOpenURL(event.url);
//inAppBrowserRef.close();
});
```
You configure the allowable schemes in a comma separated list in a new preference. This implements whitelisting for the allowed schemes, but doesn't use the Cordova Whitelist plugin -- this approach seemed much simpler and safer.
See my actual config.xml at [https://github.com/wevote/WeVoteCordova/blob/master/config.xml](https://github.com/wevote/WeVoteCordova/blob/master/config.xml)
```
<preference name="AllowedSchemes" value="mycoolapp,wevotetwitterscheme" />
```
### What testing has been done on this change?
It has been tested and is working in my app [https://github.com/wevote/WeVoteCordova](https://github.com/wevote/WeVoteCordova). I tested to make sure that single and multiple schemes in the "AllowedSchemes" preference worked as expected.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org