You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/28 03:10:24 UTC

[GitHub] [arrow] emkornfield commented on pull request #7885: ARROW-9640: [C++][Gandiva] Implement round() for integers and long integers

emkornfield commented on pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#issuecomment-682300209


   > With the vectorized round_int32_int32, why are we passing -5 as the second argument? Would be glad if you could clarify.
   
   I wanted to verify that with a static value, the function could get the multiplications necessary vectorized, since I believe this is the common case, -5 was arbitrary.  With a variable value it does not appear that the multiplications get vectorized.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org