You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/07/12 03:26:41 UTC
[GitHub] [druid] clintropolis commented on a change in pull request #10172: fix website build
clintropolis commented on a change in pull request #10172:
URL: https://github.com/apache/druid/pull/10172#discussion_r453261561
##########
File path: website/redirects.json
##########
@@ -159,7 +159,7 @@
{"source": "ingestion/command-line-hadoop-indexer.html", "target": "hadoop.html#cli"}
{"source": "ingestion/compaction.html", "target": "data-management.html#compact"}
{"source": "ingestion/delete-data.html", "target": "data-management.html#delete"}
-{"source": "ingestion/firehose.html", "target": "native-batch.html#firehoses"}
+{"source": "ingestion/firehose.html", "target": "native-batch.html#firehoses-deprecated"}
Review comment:
We actually have this, both for normal links and [these redirects](https://github.com/apache/druid/blob/master/website/script/do-redirects.js#L78), and it is how I found them, not sure why it wasn't failing the build though:
```
On line 35 could not find anchor 'firehoses' in 'ingestion/native-batch.html'
On line 50 target development/integrating-druid-with-other-technologies.html does not exist
On line 76 target operations/recommendations.html does not exist
On line 162 could not find anchor 'firehoses' in 'ingestion/native-batch.html'
There are 4 issues with the redirects
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org