You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by cmhe <gi...@git.apache.org> on 2016/11/08 14:20:52 UTC
[GitHub] thrift pull request #1125: [THRIFT-3961] TConnectedClient terminates connect...
GitHub user cmhe opened a pull request:
https://github.com/apache/thrift/pull/1125
[THRIFT-3961] TConnectedClient terminates connection when the message\u2026
\u2026 could not be processed
Signed-off-by: Claudius Heine <ch...@denx.de>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmhe/thrift THRIFT-3961
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1125
----
commit bb3b44dae735a069bde4705c732c10ae5f1eab9e
Author: Claudius Heine <ch...@denx.de>
Date: 2016-11-08T14:17:03Z
[THRIFT-3961] TConnectedClient terminates connection when the message could not be processed
Signed-off-by: Claudius Heine <ch...@denx.de>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1125: [THRIFT-3961] TConnectedClient terminates connect...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1125#discussion_r87498574
--- Diff: lib/cpp/src/thrift/server/TConnectedClient.cpp ---
@@ -86,7 +86,8 @@ void TConnectedClient::run() {
} catch (const TException& tex) {
--- End diff --
Just wondering, is catching TException enough here or should we catch std::exception here instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1125: [THRIFT-3961] TConnectedClient terminates connect...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---