You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/05/29 21:30:52 UTC
Review Request 22032: first draft of a "developing client v2" document.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Henry Saputra.
Bugs: aurora-20
https://issues.apache.org/jira/browse/aurora-20
Repository: aurora
Description
-------
first draft of a "developing client v2" document.
Diffs
-----
docs/developing-aurora-client.md PRE-CREATION
Diff: https://reviews.apache.org/r/22032/diff/
Testing
-------
n/a
Thanks,
Mark Chu-Carroll
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44295
-----------------------------------------------------------
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78647>
I'd suggest prepending the target with './pants' to give a ready to paste build command.
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78648>
s/an/a
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78649>
Suggest rewording. It's already obvious from the previous sentence that client API is on top of the primitive API.
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78650>
s/client/command line client?
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78651>
Perhaps just referencing the vagrant.md instead?
- Maxim Khutornenko
On May 29, 2014, 7:30 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22032/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 7:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Henry Saputra.
>
>
> Bugs: aurora-20
> https://issues.apache.org/jira/browse/aurora-20
>
>
> Repository: aurora
>
>
> Description
> -------
>
> first draft of a "developing client v2" document.
>
>
> Diffs
> -----
>
> docs/developing-aurora-client.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22032/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44292
-----------------------------------------------------------
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78645>
typo in Gradle
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78644>
Favor linking to the official documentation here: http://pantsbuild.github.io/python-readme.html
- Kevin Sweeney
On May 29, 2014, 12:30 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22032/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 12:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Henry Saputra.
>
>
> Bugs: aurora-20
> https://issues.apache.org/jira/browse/aurora-20
>
>
> Repository: aurora
>
>
> Description
> -------
>
> first draft of a "developing client v2" document.
>
>
> Diffs
> -----
>
> docs/developing-aurora-client.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22032/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Kevin Sweeney <ke...@apache.org>.
> On May 30, 2014, 12:38 p.m., Mark Chu-Carroll wrote:
> > docs/developing-aurora-client.md, line 5
> > <https://reviews.apache.org/r/22032/diff/1/?file=598888#file598888line5>
> >
> > The executor is an important part of aurora - but how is it part of the client? The executor is entirely a cluster-side thing running on the slaves.
> >
The executor and client have an API that the scheduler knows nothing about (the thermos task config schema). Client changes need to be mindful and aware of that component. Enumerating the components here implies exclusivity, i.e. Thermos is not a "main piece" of Aurora.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44415
-----------------------------------------------------------
On May 30, 2014, 12:40 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22032/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 12:40 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Henry Saputra.
>
>
> Bugs: aurora-20
> https://issues.apache.org/jira/browse/aurora-20
>
>
> Repository: aurora
>
>
> Description
> -------
>
> first draft of a "developing client v2" document.
>
>
> Diffs
> -----
>
> docs/developing-aurora-client.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22032/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44415
-----------------------------------------------------------
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78793>
The executor is an important part of aurora - but how is it part of the client? The executor is entirely a cluster-side thing running on the slaves.
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78794>
I think it's worth being complete here.
- Mark Chu-Carroll
On May 29, 2014, 3:30 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22032/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 3:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Henry Saputra.
>
>
> Bugs: aurora-20
> https://issues.apache.org/jira/browse/aurora-20
>
>
> Repository: aurora
>
>
> Description
> -------
>
> first draft of a "developing client v2" document.
>
>
> Diffs
> -----
>
> docs/developing-aurora-client.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22032/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44436
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On May 30, 2014, 1:14 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22032/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 1:14 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Henry Saputra.
>
>
> Bugs: aurora-20
> https://issues.apache.org/jira/browse/aurora-20
>
>
> Repository: aurora
>
>
> Description
> -------
>
> first draft of a "developing client v2" document.
>
>
> Diffs
> -----
>
> docs/developing-aurora-client.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22032/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/
-----------------------------------------------------------
(Updated May 30, 2014, 4:14 p.m.)
Review request for Aurora, David McLaughlin and Henry Saputra.
Changes
-------
More changes.
Bugs: aurora-20
https://issues.apache.org/jira/browse/aurora-20
Repository: aurora
Description
-------
first draft of a "developing client v2" document.
Diffs (updated)
-----
docs/developing-aurora-client.md PRE-CREATION
Diff: https://reviews.apache.org/r/22032/diff/
Testing
-------
n/a
Thanks,
Mark Chu-Carroll
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/
-----------------------------------------------------------
(Updated May 30, 2014, 3:40 p.m.)
Review request for Aurora, David McLaughlin and Henry Saputra.
Changes
-------
Address reviews.
Bugs: aurora-20
https://issues.apache.org/jira/browse/aurora-20
Repository: aurora
Description
-------
first draft of a "developing client v2" document.
Diffs (updated)
-----
docs/developing-aurora-client.md PRE-CREATION
Diff: https://reviews.apache.org/r/22032/diff/
Testing
-------
n/a
Thanks,
Mark Chu-Carroll
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44291
-----------------------------------------------------------
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78642>
The executor is a non-trivial big piece that one will need to be aware of when working on the client.
- Kevin Sweeney
On May 29, 2014, 12:30 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22032/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 12:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Henry Saputra.
>
>
> Bugs: aurora-20
> https://issues.apache.org/jira/browse/aurora-20
>
>
> Repository: aurora
>
>
> Description
> -------
>
> first draft of a "developing client v2" document.
>
>
> Diffs
> -----
>
> docs/developing-aurora-client.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22032/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
> On May 29, 2014, 5:10 p.m., Henry Saputra wrote:
> > Small nits but looks good overall. Will also you add remote debugging info for the scheduler in the developing-aurora-scheduler.md doc?
I'm afraid I'll have to defer to someone else for that - I haven't done it, so I have no idea what's involved.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44289
-----------------------------------------------------------
On May 29, 2014, 3:30 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22032/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 3:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Henry Saputra.
>
>
> Bugs: aurora-20
> https://issues.apache.org/jira/browse/aurora-20
>
>
> Repository: aurora
>
>
> Description
> -------
>
> first draft of a "developing client v2" document.
>
>
> Diffs
> -----
>
> docs/developing-aurora-client.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22032/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22032: first draft of a "developing client v2" document.
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44289
-----------------------------------------------------------
Ship it!
Small nits but looks good overall. Will also you add remote debugging info for the scheduler in the developing-aurora-scheduler.md doc?
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78640>
I think Kevin said that the gist already published to Pants's website/doc?
docs/developing-aurora-client.md
<https://reviews.apache.org/r/22032/#comment78639>
Missing space between "Client" and "v2"
- Henry Saputra
On May 29, 2014, 7:30 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22032/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 7:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Henry Saputra.
>
>
> Bugs: aurora-20
> https://issues.apache.org/jira/browse/aurora-20
>
>
> Repository: aurora
>
>
> Description
> -------
>
> first draft of a "developing client v2" document.
>
>
> Diffs
> -----
>
> docs/developing-aurora-client.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22032/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>