You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Matthew Lanham (Created) (JIRA)" <ji...@apache.org> on 2012/02/08 09:45:18 UTC
[jira] [Created] (CB-242) Change Reachability to PGReachability to
avoid clashes
Change Reachability to PGReachability to avoid clashes
------------------------------------------------------
Key: CB-242
URL: https://issues.apache.org/jira/browse/CB-242
Project: Apache Callback
Issue Type: Improvement
Components: iOS
Reporter: Matthew Lanham
Assignee: Shazron Abdullah
Priority: Minor
We have been manually building each time a release is out to avoid this, often we have libs in our iOS project that also package the Reachability class, it seems like that renaming it is painless and causes no adverse affects, i have forked the GitHub project and made a commit of our proposed changes, i wondered if someone could consider this being available in the main repo.
See commit here:
https://github.com/swanify/incubator-cordova-ios/commit/87b601f1c64519d91d294629208f2a215a84a822
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-242) Change Reachability to PGReachability to
avoid clashes
Posted by "Shazron Abdullah (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shazron Abdullah resolved CB-242.
---------------------------------
Resolution: Fixed
in 1.5.0 - further renamed to CDVReachability
> Change Reachability to PGReachability to avoid clashes
> ------------------------------------------------------
>
> Key: CB-242
> URL: https://issues.apache.org/jira/browse/CB-242
> Project: Apache Callback
> Issue Type: Improvement
> Components: iOS
> Reporter: Matthew Lanham
> Assignee: Shazron Abdullah
> Priority: Minor
> Fix For: 1.5.0
>
>
> We have been manually building each time a release is out to avoid this, often we have libs in our iOS project that also package the Reachability class, it seems like that renaming it is painless and causes no adverse affects, i have forked the GitHub project and made a commit of our proposed changes, i wondered if someone could consider this being available in the main repo.
> See commit here:
> https://github.com/swanify/incubator-cordova-ios/commit/87b601f1c64519d91d294629208f2a215a84a822
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-242) Change Reachability to PGReachability
to avoid clashes
Posted by "Matthew Lanham (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203407#comment-13203407 ]
Matthew Lanham commented on CB-242:
-----------------------------------
Hi Shazron,
OK, hopefully i've done it right, i've just sent the pull request:
https://github.com/apache/incubator-cordova-ios/pull/4
Thanks
Matt
> Change Reachability to PGReachability to avoid clashes
> ------------------------------------------------------
>
> Key: CB-242
> URL: https://issues.apache.org/jira/browse/CB-242
> Project: Apache Callback
> Issue Type: Improvement
> Components: iOS
> Reporter: Matthew Lanham
> Assignee: Shazron Abdullah
> Priority: Minor
> Fix For: 1.5.0
>
>
> We have been manually building each time a release is out to avoid this, often we have libs in our iOS project that also package the Reachability class, it seems like that renaming it is painless and causes no adverse affects, i have forked the GitHub project and made a commit of our proposed changes, i wondered if someone could consider this being available in the main repo.
> See commit here:
> https://github.com/swanify/incubator-cordova-ios/commit/87b601f1c64519d91d294629208f2a215a84a822
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-242) Change Reachability to PGReachability
to avoid clashes
Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203397#comment-13203397 ]
Shazron Abdullah commented on CB-242:
-------------------------------------
Thanks Matthew! please send a pull request to the main repo you forked off (ideally send a pull request from a branch that contains your changes only, not master - else the pull req could be moving target). Currently the notification system does not work - so once you send the pull request, if you could comment in this issue so I can be notified that would be great.
I attempted this sometime ago, but other pressing issues took priority. I'll review and test, and commit your changes if all goes well.
> Change Reachability to PGReachability to avoid clashes
> ------------------------------------------------------
>
> Key: CB-242
> URL: https://issues.apache.org/jira/browse/CB-242
> Project: Apache Callback
> Issue Type: Improvement
> Components: iOS
> Reporter: Matthew Lanham
> Assignee: Shazron Abdullah
> Priority: Minor
> Fix For: 1.5.0
>
>
> We have been manually building each time a release is out to avoid this, often we have libs in our iOS project that also package the Reachability class, it seems like that renaming it is painless and causes no adverse affects, i have forked the GitHub project and made a commit of our proposed changes, i wondered if someone could consider this being available in the main repo.
> See commit here:
> https://github.com/swanify/incubator-cordova-ios/commit/87b601f1c64519d91d294629208f2a215a84a822
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-242) Change Reachability to PGReachability to
avoid clashes
Posted by "Shazron Abdullah (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shazron Abdullah updated CB-242:
--------------------------------
Fix Version/s: 1.5.0
> Change Reachability to PGReachability to avoid clashes
> ------------------------------------------------------
>
> Key: CB-242
> URL: https://issues.apache.org/jira/browse/CB-242
> Project: Apache Callback
> Issue Type: Improvement
> Components: iOS
> Reporter: Matthew Lanham
> Assignee: Shazron Abdullah
> Priority: Minor
> Fix For: 1.5.0
>
>
> We have been manually building each time a release is out to avoid this, often we have libs in our iOS project that also package the Reachability class, it seems like that renaming it is painless and causes no adverse affects, i have forked the GitHub project and made a commit of our proposed changes, i wondered if someone could consider this being available in the main repo.
> See commit here:
> https://github.com/swanify/incubator-cordova-ios/commit/87b601f1c64519d91d294629208f2a215a84a822
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira