You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/23 20:16:31 UTC
[kudu-CR] KUDU-1515. Add suppression for strerror r
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5207
to review the following change.
Change subject: KUDU-1515. Add suppression for strerror_r
......................................................................
KUDU-1515. Add suppression for strerror_r
As noted in the JIRA, there's a bug in the handling of strerror_r in
TSAN. This adds the appropriate suppression.
Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
---
M build-support/tsan-suppressions.txt
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/5207/1
--
To view, visit http://gerrit.cloudera.org:8080/5207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] KUDU-1515. Add suppression for strerror r
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1515. Add suppression for strerror_r
......................................................................
Patch Set 1:
Seems like you could also do this with a scoped TSAN ignore thing in ErrnoToCString. Not sure how much of a hot path that is though.
--
To view, visit http://gerrit.cloudera.org:8080/5207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1515. Add suppressions around strerror r
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1515. Add suppressions around strerror_r
......................................................................
Patch Set 2:
yea, actually switched to that anyway because it was more effective
--
To view, visit http://gerrit.cloudera.org:8080/5207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1515. Add suppression for strerror r
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1515. Add suppression for strerror_r
......................................................................
Patch Set 1: Verified-1
apparently this wasn't sufficient
--
To view, visit http://gerrit.cloudera.org:8080/5207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1515. Add suppressions around strerror r
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5207
to look at the new patch set (#2).
Change subject: KUDU-1515. Add suppressions around strerror_r
......................................................................
KUDU-1515. Add suppressions around strerror_r
As noted in the JIRA, there's a bug in the handling of strerror_r in
TSAN. This adds the appropriate suppression around our call site.
Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
---
M src/kudu/util/errno.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/5207/2
--
To view, visit http://gerrit.cloudera.org:8080/5207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1515. Add suppressions around strerror r
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1515. Add suppressions around strerror_r
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1515. Add suppressions around strerror r
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1515. Add suppressions around strerror_r
......................................................................
KUDU-1515. Add suppressions around strerror_r
As noted in the JIRA, there's a bug in the handling of strerror_r in
TSAN. This adds the appropriate suppression around our call site.
Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
Reviewed-on: http://gerrit.cloudera.org:8080/5207
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/errno.cc
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafebf4631450ade9bb39ba7c4ec8d3bc9470c0d2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>