You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zhaojinchao95 (via GitHub)" <gi...@apache.org> on 2023/03/24 05:54:12 UTC
[GitHub] [shardingsphere] zhaojinchao95 opened a new pull request, #24797: Avoid repeat call findRules method
zhaojinchao95 opened a new pull request, #24797:
URL: https://github.com/apache/shardingsphere/pull/24797
Fixes #24690 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #24797: Avoid repeat call findRules method
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #24797:
URL: https://github.com/apache/shardingsphere/pull/24797#discussion_r1147259286
##########
jdbc/core/src/main/java/org/apache/shardingsphere/driver/jdbc/adapter/AbstractResultSetAdapter.java:
##########
@@ -46,23 +46,26 @@ public abstract class AbstractResultSetAdapter extends AbstractUnsupportedOperat
@Getter
private final Statement statement;
+ private final boolean singleTable;
Review Comment:
Do you think `transparentStatement` is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #24797: Avoid repeat call findRules method
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #24797:
URL: https://github.com/apache/shardingsphere/pull/24797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org