You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org> on 2019/02/26 17:49:02 UTC
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12593
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
When a task submitted via HdfsMonitoredOps fails, it raises
TErrorCode::THREAD_POOL_TASK_TIMED_OUT or
TErrorCode::THREAD_POOL_SUBMIT_FAILED errors. The error generated
calls GetDescription() to provide information about the failed
hdfs operation. This change appends the hostname to the description
to enable the user to easily identify the host which has reached a
bad connection state with the NameNode.
Testing:
Modified the test_hdfs_timeout.py to ensure that the hostname is
logged in the error message.
Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
---
M be/src/runtime/io/hdfs-monitored-ops.cc
M tests/custom_cluster/test_hdfs_timeout.py
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/12593/1
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12593 )
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
When a task submitted via HdfsMonitoredOps fails, it raises
TErrorCode::THREAD_POOL_TASK_TIMED_OUT or
TErrorCode::THREAD_POOL_SUBMIT_FAILED errors. The error generated
calls GetDescription() to provide information about the failed
hdfs operation. This change appends the hostname to the description
to enable the user to easily identify the host which has reached a
bad connection state with the NameNode.
Testing:
Modified the test_hdfs_timeout.py to ensure that the hostname is
logged in the error message.
Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Reviewed-on: http://gerrit.cloudera.org:8080/12593
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/io/hdfs-monitored-ops.cc
M tests/custom_cluster/test_hdfs_timeout.py
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12593 )
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
Patch Set 1:
(1 comment)
Thanks for taking this on.
http://gerrit.cloudera.org:8080/#/c/12593/1/be/src/runtime/io/hdfs-monitored-ops.cc
File be/src/runtime/io/hdfs-monitored-ops.cc:
http://gerrit.cloudera.org:8080/#/c/12593/1/be/src/runtime/io/hdfs-monitored-ops.cc@82
PS1, Line 82: return Substitute("hdfsOpenFile() for $0 at host $1", fname_, FLAGS_hostname);
I would prefer to use GetBackendString() (which has the hostname + port). i.e. "hdfsOpenFile() for $0 on backend $1"
(Then remove the DECLARE_string(hostname) above.)
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:03:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12593 )
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:23:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12593 )
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
When a task submitted via HdfsMonitoredOps fails, it raises
TErrorCode::THREAD_POOL_TASK_TIMED_OUT or
TErrorCode::THREAD_POOL_SUBMIT_FAILED errors. The error generated
calls GetDescription() to provide information about the failed
hdfs operation. This change appends the hostname to the description
to enable the user to easily identify the host which has reached a
bad connection state with the NameNode.
Testing:
Modified the test_hdfs_timeout.py to ensure that the hostname is
logged in the error message.
Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
---
M be/src/runtime/io/hdfs-monitored-ops.cc
M tests/custom_cluster/test_hdfs_timeout.py
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/12593/2
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12593 )
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3831/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:23:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12593 )
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:32:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12593 )
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2254/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:54:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12593 )
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2253/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:30:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12593 )
Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps
......................................................................
Patch Set 2: Code-Review+2
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/12593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1e21560b6fb54965f2fb2793c32c2ba5176ba2
Gerrit-Change-Number: 12593
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 18:18:30 +0000
Gerrit-HasComments: No