You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <gg...@seagullsw.com> on 2003/12/29 02:37:31 UTC
[lang] Remove checkstyle.properties?
Hello,
Since we now have checkstyle.xml, can we remove checkstyle.properties?
Gary
Re: [lang] Remove checkstyle.properties?
Posted by Martin van den Bemt <ml...@mvdb.net>.
Prepare for the worst :) esp. Avoid inline conditionals comes to mind...
Mvgr,
Martin
On Mon, 2003-12-29 at 06:42, Henri Yandell wrote:
> Sounds good. Why not just grab dbcp's and see what we (our code) disagree
> with? :)
>
> Hen
>
> On Sun, 28 Dec 2003, Phil Steitz wrote:
>
> > Gary Gregory wrote:
> > > Hello,
> > >
> > > Since we now have checkstyle.xml, can we remove checkstyle.properties?
> > >
> > > Gary
> >
> > +1
> >
> > We should also think about updating this. When I created checkstyle.xml,
> > I just translated from the existing checkstyle.properties. There is not
> > much in there. That's OK with me personally, but if we want to consider a
> > more aggressive set of checks, we might want to do some "comparative
> > shopping" among the other commons components. One that has a pretty
> > comprehensive set of checks is [dbcp].
> >
> > Phil
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
--
Martin van den Bemt <ml...@mvdb.net>
mvdb.com
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [lang] Remove checkstyle.properties?
Posted by Henri Yandell <ba...@generationjava.com>.
Sounds good. Why not just grab dbcp's and see what we (our code) disagree
with? :)
Hen
On Sun, 28 Dec 2003, Phil Steitz wrote:
> Gary Gregory wrote:
> > Hello,
> >
> > Since we now have checkstyle.xml, can we remove checkstyle.properties?
> >
> > Gary
>
> +1
>
> We should also think about updating this. When I created checkstyle.xml,
> I just translated from the existing checkstyle.properties. There is not
> much in there. That's OK with me personally, but if we want to consider a
> more aggressive set of checks, we might want to do some "comparative
> shopping" among the other commons components. One that has a pretty
> comprehensive set of checks is [dbcp].
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [lang] Remove checkstyle.properties?
Posted by Phil Steitz <ph...@steitz.com>.
Gary Gregory wrote:
> Hello,
>
> Since we now have checkstyle.xml, can we remove checkstyle.properties?
>
> Gary
+1
We should also think about updating this. When I created checkstyle.xml,
I just translated from the existing checkstyle.properties. There is not
much in there. That's OK with me personally, but if we want to consider a
more aggressive set of checks, we might want to do some "comparative
shopping" among the other commons components. One that has a pretty
comprehensive set of checks is [dbcp].
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [lang] Remove checkstyle.properties?
Posted by Stephen Colebourne <sc...@btopenworld.com>.
+1
----- Original Message -----
From: "Gary Gregory" <gg...@seagullsw.com>
To: "'Jakarta Commons Developers List'" <co...@jakarta.apache.org>
Sent: Monday, December 29, 2003 1:37 AM
Subject: [lang] Remove checkstyle.properties?
> Hello,
>
> Since we now have checkstyle.xml, can we remove checkstyle.properties?
>
> Gary
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org