[jira] [Commented] (FLINK-31603) Line break should be removed in create table with-clauses, load module with-clauses and table hints for both keys and values

["Yao Zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-31603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705214#comment-17705214 ] 

Yao Zhang commented on FLINK-31603:
-----------------------------------

Hi community,

For some of the properties like 'line.delim' in Hive, users might set the value '\n' explicitly. So it might not be a good practice to replace all line breaks in with clauses.

We may consider to narrow it down to replacing the line break in Flink Table Hints only, which needs some further discussion.

> Line break should be removed in create table with-clauses, load module with-clauses and table hints for both keys and values
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-31603
>                 URL: https://issues.apache.org/jira/browse/FLINK-31603
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.16.0, 1.16.1
>         Environment: Flink 1.16.0
>            Reporter: Yao Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.18.0
>
>
> Given a SQL like this:
> {code:sql}
> CREATE TABLE MyTable (
>   `user_id` BIGINT,
>   `name` STRING,
>   `timestamp` TIMESTAMP_LTZ(3) METADATA
> ) WITH (
>   'connector' = 'kaf
> ka'
>   ...
> );
> {code}
> After parsing the SQL, the option value 'connector' is 'kaf\nka', which will lead to problems.
> The line break inside keys/values in with-clauses and table hints should be removed when parsing SQLs.
> If this is the issue that needs to fix, I would like to do it, as I am currently working on it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)