You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/06/18 19:13:15 UTC
Review Request 70877: Updated master's /roles endpoint to use jsonify.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70877/
-----------------------------------------------------------
Review request for mesos and Meng Zhu.
Repository: mesos
Description
-------
Updated master's /roles endpoint to use jsonify.
Diffs
-----
src/common/http.hpp a0f9b67dca86f7c035035abed5d497aaf759bb10
src/common/http.cpp dcf3cb0234fc81e155dae2267764c1dd7bed5201
src/master/readonly_handler.cpp 66d6160c5e951e6c3a51eb02c31ead066c322202
Diff: https://reviews.apache.org/r/70877/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 70877: Updated master's /roles endpoint to use
jsonify.
Posted by Benjamin Mahler <bm...@apache.org>.
> On June 20, 2019, 6:36 p.m., Meng Zhu wrote:
> > src/common/http.hpp
> > Lines 219-221 (patched)
> > <https://reviews.apache.org/r/70877/diff/1/?file=2150637#file2150637line220>
> >
> > Why the namespace here and below?
It's needed to compile, clang can't seem to match the aapropriate overload otherwise
> On June 20, 2019, 6:36 p.m., Meng Zhu wrote:
> > src/master/readonly_handler.cpp
> > Line 744 (original), 701 (patched)
> > <https://reviews.apache.org/r/70877/diff/1/?file=2150639#file2150639line744>
> >
> > what is this for?
notice that `master` is used in the lambdas (this is the same style as the other jsonify handlers)
> On June 20, 2019, 6:36 p.m., Meng Zhu wrote:
> > src/master/readonly_handler.cpp
> > Lines 766-770 (original), 721-736 (patched)
> > <https://reviews.apache.org/r/70877/diff/1/?file=2150639#file2150639line768>
> >
> > Not very important, but I find putting shorter/simpler case on the top would improve readibilty.
Sounds good
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70877/#review216007
-----------------------------------------------------------
On June 18, 2019, 7:13 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70877/
> -----------------------------------------------------------
>
> (Updated June 18, 2019, 7:13 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated master's /roles endpoint to use jsonify.
>
>
> Diffs
> -----
>
> src/common/http.hpp a0f9b67dca86f7c035035abed5d497aaf759bb10
> src/common/http.cpp dcf3cb0234fc81e155dae2267764c1dd7bed5201
> src/master/readonly_handler.cpp 66d6160c5e951e6c3a51eb02c31ead066c322202
>
>
> Diff: https://reviews.apache.org/r/70877/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 70877: Updated master's /roles endpoint to use
jsonify.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70877/#review216007
-----------------------------------------------------------
Fix it, then Ship it!
Looks like we do not have quota information in `GET_ROLES`: https://github.com/apache/mesos/blob/master/include/mesos/v1/mesos.proto#L3628-L3634
Also, maybe we want to consider adding role info to the state?
src/common/http.hpp
Lines 219-221 (patched)
<https://reviews.apache.org/r/70877/#comment302949>
Why the namespace here and below?
src/master/readonly_handler.cpp
Line 744 (original), 701 (patched)
<https://reviews.apache.org/r/70877/#comment302948>
what is this for?
src/master/readonly_handler.cpp
Lines 766-770 (original), 721-736 (patched)
<https://reviews.apache.org/r/70877/#comment302947>
Not very important, but I find putting shorter/simpler case on the top would improve readibilty.
- Meng Zhu
On June 18, 2019, 12:13 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70877/
> -----------------------------------------------------------
>
> (Updated June 18, 2019, 12:13 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated master's /roles endpoint to use jsonify.
>
>
> Diffs
> -----
>
> src/common/http.hpp a0f9b67dca86f7c035035abed5d497aaf759bb10
> src/common/http.cpp dcf3cb0234fc81e155dae2267764c1dd7bed5201
> src/master/readonly_handler.cpp 66d6160c5e951e6c3a51eb02c31ead066c322202
>
>
> Diff: https://reviews.apache.org/r/70877/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 70877: Updated master's /roles endpoint to use
jsonify.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70877/#review215942
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70877]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 18, 2019, 7:13 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70877/
> -----------------------------------------------------------
>
> (Updated June 18, 2019, 7:13 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated master's /roles endpoint to use jsonify.
>
>
> Diffs
> -----
>
> src/common/http.hpp a0f9b67dca86f7c035035abed5d497aaf759bb10
> src/common/http.cpp dcf3cb0234fc81e155dae2267764c1dd7bed5201
> src/master/readonly_handler.cpp 66d6160c5e951e6c3a51eb02c31ead066c322202
>
>
> Diff: https://reviews.apache.org/r/70877/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>