You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Sanjiva Weerawarana <sa...@opensource.lk> on 2006/04/24 05:35:48 UTC

Re: svn commit: r396384 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/description/AxisService.java

On Mon, 2006-04-24 at 02:37 +0000, dims@apache.org wrote:
>      public void setSchema(XmlSchema schema) {
>          schemaList.add(schema);
> -        addScheamNameSpace(schema.getTargetNamespace());
> +        addSchemaNameSpace(schema.getTargetNamespace());
> +    }
> +
> +    public void setSchema(Collection schemas) {
> +        Iterator iterator = schemas.iterator();
> +        while(iterator.hasNext()){
> +            XmlSchema schema = (XmlSchema)iterator.next();
> +            schemaList.add(schema);
> +            addSchemaNameSpace(schema.getTargetNamespace());
> +        }
>      }

s/setSchema/setSchemaCollection/ ?

I'm personally not a big fan of overloading ;-).

Sanjiva.


Re: svn commit: r396384 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/description/AxisService.java

Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
On Mon, 2006-04-24 at 06:15 -0400, Davanum Srinivas wrote:
> Oops! meant to change that to addSchemas(). Slipped. Sorry.

Cool :). Can we change the other to addSchema() as well since it doesn't
appear to clear the list but just add ..

Thanks,

Sanjiva.


Re: svn commit: r396384 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/description/AxisService.java

Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
On Mon, 2006-04-24 at 06:15 -0400, Davanum Srinivas wrote:
> Oops! meant to change that to addSchemas(). Slipped. Sorry.

Cool :). Can we change the other to addSchema() as well since it doesn't
appear to clear the list but just add ..

Thanks,

Sanjiva.


Re: svn commit: r396384 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/description/AxisService.java

Posted by Davanum Srinivas <da...@gmail.com>.
Oops! meant to change that to addSchemas(). Slipped. Sorry.

-- dims

On 4/23/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
> On Mon, 2006-04-24 at 02:37 +0000, dims@apache.org wrote:
> >      public void setSchema(XmlSchema schema) {
> >          schemaList.add(schema);
> > -        addScheamNameSpace(schema.getTargetNamespace());
> > +        addSchemaNameSpace(schema.getTargetNamespace());
> > +    }
> > +
> > +    public void setSchema(Collection schemas) {
> > +        Iterator iterator = schemas.iterator();
> > +        while(iterator.hasNext()){
> > +            XmlSchema schema = (XmlSchema)iterator.next();
> > +            schemaList.add(schema);
> > +            addSchemaNameSpace(schema.getTargetNamespace());
> > +        }
> >      }
>
> s/setSchema/setSchemaCollection/ ?
>
> I'm personally not a big fan of overloading ;-).
>
> Sanjiva.
>
>


--
Davanum Srinivas : http://wso2.com/blogs/

Re: svn commit: r396384 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/description/AxisService.java

Posted by Davanum Srinivas <da...@gmail.com>.
Oops! meant to change that to addSchemas(). Slipped. Sorry.

-- dims

On 4/23/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
> On Mon, 2006-04-24 at 02:37 +0000, dims@apache.org wrote:
> >      public void setSchema(XmlSchema schema) {
> >          schemaList.add(schema);
> > -        addScheamNameSpace(schema.getTargetNamespace());
> > +        addSchemaNameSpace(schema.getTargetNamespace());
> > +    }
> > +
> > +    public void setSchema(Collection schemas) {
> > +        Iterator iterator = schemas.iterator();
> > +        while(iterator.hasNext()){
> > +            XmlSchema schema = (XmlSchema)iterator.next();
> > +            schemaList.add(schema);
> > +            addSchemaNameSpace(schema.getTargetNamespace());
> > +        }
> >      }
>
> s/setSchema/setSchemaCollection/ ?
>
> I'm personally not a big fan of overloading ;-).
>
> Sanjiva.
>
>


--
Davanum Srinivas : http://wso2.com/blogs/