You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/30 18:01:03 UTC
[GitHub] [flink] carp84 opened a new pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
carp84 opened a new pull request #11965:
URL: https://github.com/apache/flink/pull/11965
## What is the purpose of the change
Fix the legal issue in `flink-sql-connector-elasticsearch7` as reported by FLINK-17483
## Brief change log
Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies, including:
* com.carrotsearch:hppc:0.8.1
* com.github.spullara.mustache.java:compiler:0.9.3
* org.elasticsearch:elasticsearch-geo:7.3.2
* org.elasticsearch.plugin:lang-mustache-client:7.3.2
## Verifying this change
Manually compare the output of shaded plugin and the entries in the NOTICE file, make sure they are in accordance.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11965:
URL: https://github.com/apache/flink/pull/11965#issuecomment-622022121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4061d02d1ba7a311961f3008cbbba46a27aba6c6",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/163051341",
"triggerID" : "4061d02d1ba7a311961f3008cbbba46a27aba6c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4061d02d1ba7a311961f3008cbbba46a27aba6c6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/163051341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11965:
URL: https://github.com/apache/flink/pull/11965#issuecomment-622022121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4061d02d1ba7a311961f3008cbbba46a27aba6c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4061d02d1ba7a311961f3008cbbba46a27aba6c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4061d02d1ba7a311961f3008cbbba46a27aba6c6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #11965:
URL: https://github.com/apache/flink/pull/11965#issuecomment-622011596
CC @zentol @rmetzger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11965:
URL: https://github.com/apache/flink/pull/11965#issuecomment-622022121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4061d02d1ba7a311961f3008cbbba46a27aba6c6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/163051341",
"triggerID" : "4061d02d1ba7a311961f3008cbbba46a27aba6c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4061d02d1ba7a311961f3008cbbba46a27aba6c6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/163051341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11965:
URL: https://github.com/apache/flink/pull/11965#discussion_r418204991
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -6,10 +6,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+- com.carrotsearch:hppc:0.8.1
Review comment:
hppc has a NOTICE file that we need to forward: https://github.com/carrotsearch/hppc/blob/0.8.1/NOTICE.txt
I could not find it in this archive: https://repository.apache.org/content/repositories/orgapacheflink-1362/org/apache/flink/flink-sql-connector-elasticsearch7_2.11/1.10.1/flink-sql-connector-elasticsearch7_2.11-1.10.1.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11965:
URL: https://github.com/apache/flink/pull/11965#discussion_r418222872
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -6,10 +6,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+- com.carrotsearch:hppc:0.8.1
Review comment:
Thanks a lot for this pointer! I learned something new about licenses tonight.
I rest my case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #11965:
URL: https://github.com/apache/flink/pull/11965#issuecomment-622242664
Thanks all for the review, and thanks @zentol for the reminder, will open another PR against master branch and watch the version updates of es.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11965:
URL: https://github.com/apache/flink/pull/11965#discussion_r418217715
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -6,10 +6,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+- com.carrotsearch:hppc:0.8.1
Review comment:
Since the jar does not contain the NOTICE we do not have to forward it imo.
> (d) **If** the Work includes a "NOTICE" text file as part of its
> **distribution**, then any Derivative Works that You distribute must
> include a readable copy of the attribution notices contained
> within such NOTICE file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11965:
URL: https://github.com/apache/flink/pull/11965#discussion_r418217715
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -6,10 +6,12 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+- com.carrotsearch:hppc:0.8.1
Review comment:
Since the jar does not contain the NOTICE we do not have to forward it imo.
> (d) If the Work includes a "NOTICE" text file as part of its
> **distribution**, then any Derivative Works that You distribute must
> include a readable copy of the attribution notices contained
> within such NOTICE file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11965: [FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11965:
URL: https://github.com/apache/flink/pull/11965#issuecomment-622014535
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4061d02d1ba7a311961f3008cbbba46a27aba6c6 (Thu Apr 30 18:07:33 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org