[jira] [Updated] (KAFKA-579) remove connection timeout in SyncProducer

["Swapnil Ghike (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Swapnil Ghike updated KAFKA-579:
--------------------------------

    Attachment: kafka-579-v1.patch

1. Modified syncProducer.connect() to not backoff and directly return the exception to the caller.

2. Removed forced reconnect() from syncProducer.doSend() since that was probably useful only in case of load balancing with VIP.

3. Removed connectTimeoutMs, reconnectInterval and reconnectTimeInterval from SyncProducerConfig. 

4. Unrelated: Removed numRetries from ProducerConfig and preferredReplicaWaitTime from KafkaConfig, since they were not being used. 
                
> remove connection timeout in SyncProducer
> -----------------------------------------
>
>                 Key: KAFKA-579
>                 URL: https://issues.apache.org/jira/browse/KAFKA-579
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: bugs, newbie
>         Attachments: kafka-579-v1.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, SyncProducer has a few parameters that control how long the client should wait to establish a socket connection and how frequent the connection should be re-established. Those parameters seem to be needed primarily for vip on a load balancer. In 0.8, SyncProducer doesn't deal with VIP any more. So, we probably should get rid of those parameters. One of the issues that I have seen is that when a broker is down, SyncProducer will still wait connectionTimeout time to try to establish a connection. This is unnecessary since the high level producer already has the retry logic and is delaying requests like getMetadataRequest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira