[jira] [Commented] (KAFKA-5543) We don't remove the LastStableOffsetLag metric when a partition is moved away from a broker

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069198#comment-16069198 ] 

ASF GitHub Bot commented on KAFKA-5543:
---------------------------------------

GitHub user apurvam opened a pull request:

    https://github.com/apache/kafka/pull/3462

    KAFKA-5543: Remove all partition metrics when a topic is deleted

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apurvam/kafka KAFKA-5543-remove-lastStableOffsetLag-metric

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3462
    
----
commit f315bbdcd0a26755db1a7169822279f8965c5309
Author: Apurva Mehta <ap...@confluent.io>
Date:   2017-06-29T23:41:58Z

    Remove all partition metrics when a topic is deleted

----


> We don't remove the LastStableOffsetLag metric when a partition is moved away from a broker
> -------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5543
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5543
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.11.0.0
>            Reporter: Apurva Mehta
>            Assignee: Apurva Mehta
>             Fix For: 0.11.0.1
>
>
> Reported by [~junrao], we have a small leak where the `LastStableOffsetLag` metric is not removed along with the other metrics in the `Partition.removeMetrics` method. This could create a leak when partitions are reassigned or a topic is deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)