You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2016/08/02 00:06:20 UTC

mesos git commit: Do not set allocation_interval in allocator benchmark test.

Repository: mesos
Updated Branches:
  refs/heads/master 8dc71da12 -> 988ebc878


Do not set allocation_interval in allocator benchmark test.

We already using `Clock::pause();` to manually drive the allocations,
so here we can remove the logic of set allocation_interval here.

Review: https://reviews.apache.org/r/50678/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/988ebc87
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/988ebc87
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/988ebc87

Branch: refs/heads/master
Commit: 988ebc878409429f666118019b627b5699fc9e67
Parents: 8dc71da
Author: Guangya Liu <gy...@gmail.com>
Authored: Mon Aug 1 16:42:25 2016 -0700
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Mon Aug 1 16:42:25 2016 -0700

----------------------------------------------------------------------
 src/tests/hierarchical_allocator_tests.cpp | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/988ebc87/src/tests/hierarchical_allocator_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/hierarchical_allocator_tests.cpp b/src/tests/hierarchical_allocator_tests.cpp
index e557602..cbed333 100644
--- a/src/tests/hierarchical_allocator_tests.cpp
+++ b/src/tests/hierarchical_allocator_tests.cpp
@@ -3449,12 +3449,6 @@ TEST_P(HierarchicalAllocator_BENCHMARK_Test, DeclineOffers)
   size_t slaveCount = std::tr1::get<0>(GetParam());
   size_t frameworkCount = std::tr1::get<1>(GetParam());
 
-  master::Flags flags;
-
-  // Choose an interval longer than the time we expect a single cycle to take so
-  // that we don't back up the process queue.
-  flags.allocation_interval = Hours(1);
-
   // Pause the clock because we want to manually drive the allocations.
   Clock::pause();
 
@@ -3485,7 +3479,7 @@ TEST_P(HierarchicalAllocator_BENCHMARK_Test, DeclineOffers)
   vector<FrameworkInfo> frameworks;
   frameworks.reserve(frameworkCount);
 
-  initialize(flags, offerCallback);
+  initialize(master::Flags(), offerCallback);
 
   Stopwatch watch;
   watch.start();
@@ -3595,12 +3589,6 @@ TEST_P(HierarchicalAllocator_BENCHMARK_Test, ResourceLabels)
   size_t slaveCount = std::tr1::get<0>(GetParam());
   size_t frameworkCount = std::tr1::get<1>(GetParam());
 
-  master::Flags flags;
-
-  // Choose an interval longer than the time we expect a single cycle to take so
-  // that we don't back up the process queue.
-  flags.allocation_interval = Hours(1);
-
   // Pause the clock because we want to manually drive the allocations.
   Clock::pause();
 
@@ -3631,7 +3619,7 @@ TEST_P(HierarchicalAllocator_BENCHMARK_Test, ResourceLabels)
   vector<FrameworkInfo> frameworks;
   frameworks.reserve(frameworkCount);
 
-  initialize(flags, offerCallback);
+  initialize(master::Flags(), offerCallback);
 
   Stopwatch watch;
   watch.start();