You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "alexandre parenteau (JIRA)" <ji...@apache.org> on 2011/09/12 22:11:10 UTC
[jira] [Created] (THRIFT-1341) TProtocol.h endian detection wrong
with boost
TProtocol.h endian detection wrong with boost
---------------------------------------------
Key: THRIFT-1341
URL: https://issues.apache.org/jira/browse/THRIFT-1341
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.7, 0.8
Environment: Windows
Reporter: alexandre parenteau
Priority: Trivial
Fix For: 0.8
Attachments: THRIFT-1341.patch
When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), TProtocol.h uses boost to detect the endianess, but does it wrong: boost's endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike endian.h)
Attached is a patch against trunk which fixes the code that uses boost. Tested on Windows, boost 1.44.0.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1341) TProtocol.h endian detection wrong
with boost
Posted by "alexandre parenteau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
alexandre parenteau updated THRIFT-1341:
----------------------------------------
Attachment: THRIFT-1341.patch
Fix boost endianness detection
> TProtocol.h endian detection wrong with boost
> ---------------------------------------------
>
> Key: THRIFT-1341
> URL: https://issues.apache.org/jira/browse/THRIFT-1341
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7, 0.8
> Environment: Windows
> Reporter: alexandre parenteau
> Priority: Trivial
> Labels: patch
> Fix For: 0.8
>
> Attachments: THRIFT-1341.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), TProtocol.h uses boost to detect the endianess, but does it wrong: boost's endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike endian.h)
> Attached is a patch against trunk which fixes the code that uses boost. Tested on Windows, boost 1.44.0.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1341) TProtocol.h endian detection wrong
with boost
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103162#comment-13103162 ]
Hudson commented on THRIFT-1341:
--------------------------------
Integrated in Thrift #261 (See [https://builds.apache.org/job/Thrift/261/])
THRIFT-1341 TProtocol.h endian detection wrong with boost
Patch: alexandre parenteau
roger : http://svn.apache.org/viewvc/?view=rev&rev=1169963
Files :
* /thrift/trunk/lib/cpp/src/protocol/TProtocol.h
> TProtocol.h endian detection wrong with boost
> ---------------------------------------------
>
> Key: THRIFT-1341
> URL: https://issues.apache.org/jira/browse/THRIFT-1341
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7, 0.8
> Environment: Windows
> Reporter: alexandre parenteau
> Priority: Trivial
> Labels: patch
> Fix For: 0.8
>
> Attachments: THRIFT-1341.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), TProtocol.h uses boost to detect the endianess, but does it wrong: boost's endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike endian.h)
> Attached is a patch against trunk which fixes the code that uses boost. Tested on Windows, boost 1.44.0.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1341) TProtocol.h endian detection wrong
with boost
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1341.
---------------------------------
Resolution: Fixed
Thanks Alexandre!
> TProtocol.h endian detection wrong with boost
> ---------------------------------------------
>
> Key: THRIFT-1341
> URL: https://issues.apache.org/jira/browse/THRIFT-1341
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.7, 0.8
> Environment: Windows
> Reporter: alexandre parenteau
> Priority: Trivial
> Labels: patch
> Fix For: 0.8
>
> Attachments: THRIFT-1341.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), TProtocol.h uses boost to detect the endianess, but does it wrong: boost's endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike endian.h)
> Attached is a patch against trunk which fixes the code that uses boost. Tested on Windows, boost 1.44.0.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira