[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #2969: feat(bindings/nodejs): Implement presign test

["suyanhanx (via GitHub)" <gi...@apache.org>]

suyanhanx commented on code in PR #2969:
URL: https://github.com/apache/incubator-opendal/pull/2969#discussion_r1308465659


##########
bindings/nodejs/tests/binding.js:
##########
@@ -75,6 +75,12 @@ Then('The async file {string} must have content {string}', async function (path,
   assert(bs.toString() == content)
 })
 
-Then('The presign operation should success or raise exception Unsupported', function () {
-  // TODO: please implement me.
+Then('The presign operation should success or raise exception Unsupported', async function () {
+  try {
+    await this.op.presignStat('path', 1000)
+    await this.op.presignRead('path', 1000)
+    await this.op.presignWrite('path', 1000)
+  } catch (e) {
+    assert.ok(e.message.includes('Unsupported'))

Review Comment:
   Due to the lack of a proper ErrorKind in napi-rs, we can only check the inner error's content.
    
   Nodejs could also check an error`s kind by calling `e.code`.



##########
bindings/nodejs/tests/binding.js:
##########
@@ -75,6 +75,12 @@ Then('The async file {string} must have content {string}', async function (path,
   assert(bs.toString() == content)
 })
 
-Then('The presign operation should success or raise exception Unsupported', function () {
-  // TODO: please implement me.
+Then('The presign operation should success or raise exception Unsupported', async function () {
+  try {
+    await this.op.presignStat('path', 1000)
+    await this.op.presignRead('path', 1000)
+    await this.op.presignWrite('path', 1000)
+  } catch (e) {
+    assert.ok(e.message.includes('Unsupported'))

Review Comment:
   Due to the lack of a proper ErrorKind in napi-rs, we can only check the inner error's content.
    
   Nodejs could also check an error's kind by calling `e.code`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org