You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/20 19:33:13 UTC
svn commit: r1696828 - in /commons/proper/bcel/trunk: checkstyle.xml
src/main/java/org/apache/commons/bcel6/classfile/Utility.java
src/main/java/org/apache/commons/bcel6/util/CodeHTML.java
Author: sebb
Date: Thu Aug 20 17:33:13 2015
New Revision: 1696828
URL: http://svn.apache.org/r1696828
Log:
Checkstyle
Modified:
commons/proper/bcel/trunk/checkstyle.xml
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java
Modified: commons/proper/bcel/trunk/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/checkstyle.xml?rev=1696828&r1=1696827&r2=1696828&view=diff
==============================================================================
--- commons/proper/bcel/trunk/checkstyle.xml (original)
+++ commons/proper/bcel/trunk/checkstyle.xml Thu Aug 20 17:33:13 2015
@@ -149,7 +149,7 @@ limitations under the License.
<module name="FallThrough">
<property name="reliefPattern" value="\$FALL-THROUGH\$"/><!-- to agree with Eclipse -->
</module>
- <!--module name="MultipleVariableDeclarations"/-->
+ <module name="MultipleVariableDeclarations"/>
<!--module name="UnnecessaryParentheses"/-->
<!-- Checks for class design -->
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java?rev=1696828&r1=1696827&r2=1696828&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java Thu Aug 20 17:33:13 2015
@@ -187,10 +187,17 @@ public abstract class Utility {
public static String codeToString( ByteSequence bytes, ConstantPool constant_pool,
boolean verbose ) throws IOException {
short opcode = (short) bytes.readUnsignedByte();
- int default_offset = 0, low, high, npairs;
- int index, vindex, constant;
- int[] match, jump_table;
- int no_pad_bytes = 0, offset;
+ int default_offset = 0;
+ int low;
+ int high;
+ int npairs;
+ int index;
+ int vindex;
+ int constant;
+ int[] match;
+ int[] jump_table;
+ int no_pad_bytes = 0;
+ int offset;
StringBuilder buf = new StringBuilder(Constants.OPCODE_NAMES[opcode]);
/* Special case: Skip (0-3) padding bytes, i.e., the
* following bytes are 4-byte-aligned
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java?rev=1696828&r1=1696827&r2=1696828&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java Thu Aug 20 17:33:13 2015
@@ -79,13 +79,19 @@ final class CodeHTML {
*/
private String codeToHTML( ByteSequence bytes, int method_number ) throws IOException {
short opcode = (short) bytes.readUnsignedByte();
- StringBuilder buf;
- String name, signature;
- int default_offset = 0, low, high;
- int index, class_index, vindex, constant;
+ String name;
+ String signature;
+ int default_offset = 0;
+ int low;
+ int high;
+ int index;
+ int class_index;
+ int vindex;
+ int constant;
int[] jump_table;
- int no_pad_bytes = 0, offset;
- buf = new StringBuilder(256);
+ int no_pad_bytes = 0;
+ int offset;
+ StringBuilder buf = new StringBuilder(256);
buf.append("<TT>").append(Constants.OPCODE_NAMES[opcode]).append("</TT></TD><TD>");
/* Special case: Skip (0-3) padding bytes, i.e., the
* following bytes are 4-byte-aligned