You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/29 12:27:01 UTC

[GitHub] [hudi] codope opened a new pull request, #6247: [MINOR] Add license header

codope opened a new pull request, #6247:
URL: https://github.com/apache/hudi/pull/6247

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6247: [MINOR] Add license header

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6247:
URL: https://github.com/apache/hudi/pull/6247#issuecomment-1199242806

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1c96edb81b1623c50975c8d3fd81241a81e40445",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10457",
       "triggerID" : "1c96edb81b1623c50975c8d3fd81241a81e40445",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1c96edb81b1623c50975c8d3fd81241a81e40445 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10457) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] codope merged pull request #6247: [MINOR] Add license header

Posted by GitBox <gi...@apache.org>.
codope merged PR #6247:
URL: https://github.com/apache/hudi/pull/6247


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] codope commented on pull request #6247: [MINOR] Add license header

Posted by GitBox <gi...@apache.org>.
codope commented on PR #6247:
URL: https://github.com/apache/hudi/pull/6247#issuecomment-1200419204

   > I was thinking the plugin would have checked the missing header.
   
   The plugin works fine but we set `-Drat.skip=true` for tests, e.g. https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=10474&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=e0ae894b-41c9-5f4b-7ed2-bdf5243b02e7&l=15
   I ran `mvn apache-rat:check -pl hudi-sync/hudi-sync-common` locally and that was able to identify the file w/o license header.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6247: [MINOR] Add license header

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6247:
URL: https://github.com/apache/hudi/pull/6247#issuecomment-1199344177

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1c96edb81b1623c50975c8d3fd81241a81e40445",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10457",
       "triggerID" : "1c96edb81b1623c50975c8d3fd81241a81e40445",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1c96edb81b1623c50975c8d3fd81241a81e40445 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10457) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6247: [MINOR] Add license header

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6247:
URL: https://github.com/apache/hudi/pull/6247#issuecomment-1199234091

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1c96edb81b1623c50975c8d3fd81241a81e40445",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1c96edb81b1623c50975c8d3fd81241a81e40445",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1c96edb81b1623c50975c8d3fd81241a81e40445 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org