[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1413: nimble/phy/nrf5x: Implement NRF5340 errata 158

[GitBox <gi...@apache.org>]

apache-mynewt-bot commented on PR #1413:
URL: https://github.com/apache/mynewt-nimble/pull/1413#issuecomment-1332805487

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/drivers/nrf5x/src/ble_phy.c
   <details>
   
   ```diff
   @@ -1522,12 +1521,12 @@
    #ifdef NRF53_SERIES
        /* Errata 158: load trim values after toggling power */
        for (uint32_t index = 0; index < 32ul &&
   -         NRF_FICR_NS->TRIMCNF[index].ADDR != (uint32_t *)0xFFFFFFFFul; index++){
   +         NRF_FICR_NS->TRIMCNF[index].ADDR != (uint32_t *)0xFFFFFFFFul; index++) {
            *((volatile uint32_t *)NRF_FICR_NS->TRIMCNF[index].ADDR) = NRF_FICR_NS->TRIMCNF[index].DATA;
        }
    
        *(volatile uint32_t *)(NRF_RADIO_NS_BASE + 0x774) =
   -        (*(volatile uint32_t* )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
   +        (*(volatile uint32_t * )(NRF_RADIO_NS_BASE + 0x774) & 0xfffffffe) | 0x01000000;
    #if NRF53_ERRATA_16_ENABLE_WORKAROUND
        if (nrf53_errata_16()) {
            /* [16] RADIO: POWER register is not functional */
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org