Re: Review Request: HFTP coordinator input check fails due to missing commons-httpclient.jar

[Ryota Egashira <eg...@yahoo-inc.com>]

> On Nov. 30, 2012, 1:10 p.m., Rohini Palaniswamy wrote:
> > branches/branch-3.3/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java, line 427
> > <https://reviews.apache.org/r/8264/diff/3/?file=231859#file231859line427>
> >
> >     Please use Error instead of NoClassDefFoundError and put this block further up in the execution which is common to all commands may be like XCommand. The idea is to know about any errors happening during any command execution.
> 
> Ryota Egashira wrote:
>     I don't agree with it. it is safe to be specific when catching error, since we should minimize risk to absorb error by mistake, which is the worst thing.
> 
> Rohini Palaniswamy wrote:
>     We are throwing back the error. So there is no risk of absorbing it. It is only for the purpose of logging to know that a Error happened instead of being clueless about the issue.
> 
> Ryota Egashira wrote:
>     > We are throwing back the error.
>     yes i know, what I'm talking about is other people could remove throwing part (just one line) by mistake when they don't have context, then very bad. 
>     also error could happen due to many other reason. we should solve issue one at time, this jira is to detect missing lib issue. 
>     
>     
>     
>
> 
> Rohini Palaniswamy wrote:
>     Code goes through review. So someone removing it by accident should not be a big concern. The plan of logging the error further up in the code stack is to know about issues that may happen anywhere else in the code in future. It doesn't help much if you are just trying to catch one particular error in one place for which you have already done a fix.

discussed with Rohini. we solve logging of error in OOZIE-1110


- Ryota


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8264/#review13896
-----------------------------------------------------------


On Nov. 30, 2012, 7:05 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8264/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 7:05 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1100
> 
> 
> This addresses bug OOZIE-1100.
>     https://issues.apache.org/jira/browse/OOZIE-1100
> 
> 
> Diffs
> -----
> 
>   branches/branch-3.3/core/pom.xml 1415057 
>   branches/branch-3.3/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1415057 
>   branches/branch-3.3/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1415057 
>   branches/branch-3.3/core/src/main/resources/oozie-default.xml 1415057 
>   branches/branch-3.3/pom.xml 1415057 
>   branches/branch-3.3/webapp/pom.xml 1415057 
> 
> Diff: https://reviews.apache.org/r/8264/diff/
> 
> 
> Testing
> -------
> 
> setup single-node H23 cluster locally and tested.
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>