You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/18 10:15:28 UTC

[GitHub] [calcite] danny0405 edited a comment on pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 edited a comment on pull request #2016:
URL: https://github.com/apache/calcite/pull/2016#issuecomment-645923910


   > Regarding my concern about memory usage, I was talking about `Digest` and the extra list used to store `items` which is kind of redundant with the `RelNode` itself. An alternative could have to replace the list of extra fields with an `Iterable` and call it each time items need to be collected? It could also possibly eliminate the creation of an array to do a comparison between objects...
   
   What do you mean by extra fields ? If possible, can you give a POC code there, the discussion with all kinds of assumptions make me burden out.
   
   And if possible, use the code here https://github.com/apache/calcite/pull/2034 to illustrate that you are right.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org