You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2019/03/24 04:34:42 UTC

Review Request 70291: Added gcr registry test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70291/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.


Bugs: MESOS-6934
    https://issues.apache.org/jira/browse/MESOS-6934


Repository: mesos


Description
-------

Added gcr registry test.


Diffs
-----

  src/tests/containerizer/provisioner_docker_tests.cpp a2a7f11eeb533d7790890988061612e11a798067 


Diff: https://reviews.apache.org/r/70291/diff/1/


Testing
-------


Thanks,

Gilbert Song


Re: Review Request 70291: Added gcr registry test.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70291/#review213953
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70287', '70288', '70289', '70290', '70291']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3005/mesos-review-70291

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3005/mesos-review-70291/logs/mesos-tests.log):

```
I0324 07:10:43.069412 25940 master.cpp:3349] Deactivating agent 36453d2f-7b89-4073-8a08-62b4a109ede1-S0 at slave(496)@192.10.1.6:59721 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0324 07:10:43.069412 28024 hierarchical.cpp:391] Removed framework 36453d2f-7b89-4073-8a08-62b4a109ede1-0000
I0324 07:10:43.070396 28024 hierarchical.cpp:828] Agent 36453d2f-7b89-4073-8a08-62b4a109ede1-S0 deactivated
I0324 07:10:43.071414 28024 containerizer.cpp:2576] Destroying container d89ecd81-b1e8-410b-bed7-ee17f5322436 in RUNNING state
I0324 07:10:43.071414 28024 containerizer.cpp:3278] Transitioning the state of container d89ecd81-b1e8-410b-bed7-ee17f5322436 from RUNNING to DESTROYING
I0324 07:10:43.071414 28024 launcher.cpp:161] Asked to destroy container d89ecd81-b1e8-410b-bed7-ee17f5322436
W0324 07:10:43.072419 31888 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=6728 to peer '192.10.1.6:62066': IO failed with error code: The specified network name is no longer available.

W0324 07:10:43.073395 31888 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=10364 to peer '192.10.1.6:62067'[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (686 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (702 ms total)

[----------] Global test environment tear-down
[==========] 1125 tests from 107 test cases ran. (512047 ms total)
[  PASSED  ] 1121 tests.
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchV2S2Image
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 4 FAILED TESTS
  YOU HAVE 231 DISABLED TESTS

: IO failed with error code: The specified network name is no longer available.

I0324 07:10:43.173990 30416 containerizer.cpp:3117] Container d89ecd81-b1e8-410b-bed7-ee17f5322436 has exited
I0324 07:10:43.202042 11320 master.cpp:1135] Master terminating
I0324 07:10:43.203001 26668 hierarchical.cpp:679] Removed agent 36453d2f-7b89-4073-8a08-62b4a109ede1-S0
I0324 07:10:43.650045 31888 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 24, 2019, 4:34 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70291/
> -----------------------------------------------------------
> 
> (Updated March 24, 2019, 4:34 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added gcr registry test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp a2a7f11eeb533d7790890988061612e11a798067 
> 
> 
> Diff: https://reviews.apache.org/r/70291/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Re: Review Request 70291: Added gcr registry test.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70291/#review213970
-----------------------------------------------------------




src/tests/containerizer/provisioner_docker_tests.cpp
Lines 634-638 (original), 634-639 (patched)
<https://reviews.apache.org/r/70291/#comment300098>

    I think we should use `alpine` (e.g., gcr.io/google-containers/alpine-with-bash) since the prefix here is `ImageAlpine`.


- Qian Zhang


On March 24, 2019, 12:34 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70291/
> -----------------------------------------------------------
> 
> (Updated March 24, 2019, 12:34 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added gcr registry test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp a2a7f11eeb533d7790890988061612e11a798067 
> 
> 
> Diff: https://reviews.apache.org/r/70291/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Re: Review Request 70291: Added gcr registry test.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70291/#review214366
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On April 3, 2019, 3:18 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70291/
> -----------------------------------------------------------
> 
> (Updated April 3, 2019, 3:18 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added gcr registry test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp a2a7f11eeb533d7790890988061612e11a798067 
> 
> 
> Diff: https://reviews.apache.org/r/70291/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Re: Review Request 70291: Added gcr registry test.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70291/
-----------------------------------------------------------

(Updated April 3, 2019, 12:18 a.m.)


Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.


Bugs: MESOS-6934
    https://issues.apache.org/jira/browse/MESOS-6934


Repository: mesos


Description
-------

Added gcr registry test.


Diffs (updated)
-----

  src/tests/containerizer/provisioner_docker_tests.cpp a2a7f11eeb533d7790890988061612e11a798067 


Diff: https://reviews.apache.org/r/70291/diff/3/

Changes: https://reviews.apache.org/r/70291/diff/2-3/


Testing
-------


Thanks,

Gilbert Song


Re: Review Request 70291: Added gcr registry test.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70291/
-----------------------------------------------------------

(Updated April 2, 2019, 1:11 a.m.)


Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.


Bugs: MESOS-6934
    https://issues.apache.org/jira/browse/MESOS-6934


Repository: mesos


Description
-------

Added gcr registry test.


Diffs (updated)
-----

  src/tests/containerizer/provisioner_docker_tests.cpp a2a7f11eeb533d7790890988061612e11a798067 


Diff: https://reviews.apache.org/r/70291/diff/2/

Changes: https://reviews.apache.org/r/70291/diff/1-2/


Testing
-------


Thanks,

Gilbert Song