[GitHub] [spark] cloud-fan commented on a change in pull request #30003: [SPARK-32709][SQL] Support write Hive ORC/Parquet bucketed table (for Hive 1,2)

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #30003:
URL: https://github.com/apache/spark/pull/30003#discussion_r504467380



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala
##########
@@ -230,9 +236,9 @@ class DynamicPartitionDataWriter(
       description.customPartitionLocations.get(PartitioningUtils.parsePathFragment(dir))
     }
     val currentPath = if (customPath.isDefined) {
-      committer.newTaskTempFileAbsPath(taskAttemptContext, customPath.get, ext)
+      committer.newTaskTempFileAbsPath(taskAttemptContext, customPath.get, prefix, ext)

Review comment:
       We need the `prefix` parameter because we want to put the bucket id at the beginning of the file name?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org