You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/24 03:39:01 UTC

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation
URL: https://github.com/apache/flink/pull/8499#discussion_r287192634
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/FlinkPhysicalRel.scala
 ##########
 @@ -37,6 +37,6 @@ trait FlinkPhysicalRel extends FlinkRelNode {
     * @return A converted node which satisfy required traits by inputs node of current node.
     *         Returns null if required traits cannot be pushed down into inputs.
 
 Review comment:
   Returns null if required traits cannot be satisfied.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services