[GitHub] [thrift] allengeorge commented on pull request #2426: THRIFT-5446: Added code-gen for rust async read.

[GitBox <gi...@apache.org>]

allengeorge commented on pull request #2426:
URL: https://github.com/apache/thrift/pull/2426#issuecomment-890546380


   First off, thank you for starting work on this feature!
   
   A couple of high-level thoughts from skimming through the code. I _wonder_ if there's a better way of generalizing the functions than adding an `is_sync` flag everywhere and repeating the `is_sync` block in multiple places to add the `async` prefix and use `.await?`. There are a couple of places where we now call a function with multiple boolean args, and without keyword args it can get confusing.
   
   Next, I would like to see a rough cut of how `TInputStreamProtocol` is implemented, just to see how everything fits together.
   
   Finally, I've never used `async-trait`. Do you know if the Thrift generator requires any features that are _not_ supported by it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org