You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/08/26 17:48:10 UTC
Review Request 25063: Config History: API should create exactly one
SCV when instructed to save multiple configs in a batch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25063/
-----------------------------------------------------------
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-7015
https://issues.apache.org/jira/browse/AMBARI-7015
Repository: ambari
Description
-------
When the API client makes a call to save multiple configs for a service in batch, the server ends up creating multiple SCVs. This should result in only one SCV.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java c465189
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java 14cc6be
ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java f3668c1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java a881730
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b0e2dd4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 559f64d
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8970961
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 1161cc6
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java ee6952a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 4d68402
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 847a34d
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ca76dc5
ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java e13c25e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 7d51184
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 94bd0c2
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java ffd4358
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 222924b
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java e794e01
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java c0bdaa2
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java f8d16c8
Diff: https://reviews.apache.org/r/25063/diff/
Testing
-------
Thanks,
Dmytro Sen
Re: Review Request 25063: Config History: API should create exactly
one SCV when instructed to save multiple configs in a batch
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25063/#review51533
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Сер. 26, 2014, 7:11 після полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25063/
> -----------------------------------------------------------
>
> (Updated Сер. 26, 2014, 7:11 після полудня)
>
>
> Review request for Ambari and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-7015
> https://issues.apache.org/jira/browse/AMBARI-7015
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When the API client makes a call to save multiple configs for a service in batch, the server ends up creating multiple SCVs. This should result in only one SCV.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java c465189
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java 14cc6be
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java f3668c1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java a881730
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b0e2dd4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 559f64d
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8970961
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 1161cc6
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java ee6952a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 4d68402
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 847a34d
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ca76dc5
> ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java e13c25e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 7d51184
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 94bd0c2
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java ffd4358
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 222924b
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java e794e01
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java c0bdaa2
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java f8d16c8
>
> Diff: https://reviews.apache.org/r/25063/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [5.254s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.305s]
> [INFO] Ambari Web ........................................ SUCCESS [30.446s]
> [INFO] Ambari Views ...................................... SUCCESS [2.000s]
> [INFO] Ambari Admin View ................................. SUCCESS [32.327s]
> [INFO] Ambari Server ..................................... SUCCESS [18:09.137s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.148s]
> [INFO] Ambari Client ..................................... SUCCESS [0.089s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.518s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [9.430s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.048s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.128s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [5.654s]
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 25063: Config History: API should create exactly
one SCV when instructed to save multiple configs in a batch
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25063/
-----------------------------------------------------------
(Updated Авг. 26, 2014, 4:11 п.п.)
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-7015
https://issues.apache.org/jira/browse/AMBARI-7015
Repository: ambari
Description
-------
When the API client makes a call to save multiple configs for a service in batch, the server ends up creating multiple SCVs. This should result in only one SCV.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java c465189
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java 14cc6be
ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java f3668c1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java a881730
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b0e2dd4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 559f64d
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8970961
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 1161cc6
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java ee6952a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 4d68402
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 847a34d
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ca76dc5
ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java e13c25e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 7d51184
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 94bd0c2
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java ffd4358
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 222924b
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java e794e01
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java c0bdaa2
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java f8d16c8
Diff: https://reviews.apache.org/r/25063/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [5.254s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.305s]
[INFO] Ambari Web ........................................ SUCCESS [30.446s]
[INFO] Ambari Views ...................................... SUCCESS [2.000s]
[INFO] Ambari Admin View ................................. SUCCESS [32.327s]
[INFO] Ambari Server ..................................... SUCCESS [18:09.137s]
[INFO] Ambari Agent ...................................... SUCCESS [6.148s]
[INFO] Ambari Client ..................................... SUCCESS [0.089s]
[INFO] Ambari Python Client .............................. SUCCESS [0.518s]
[INFO] Ambari Groovy Client .............................. SUCCESS [9.430s]
[INFO] Ambari Shell ...................................... SUCCESS [0.048s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.128s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [5.654s]
Thanks,
Dmytro Sen
Re: Review Request 25063: Config History: API should create exactly
one SCV when instructed to save multiple configs in a batch
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25063/
-----------------------------------------------------------
(Updated Авг. 26, 2014, 4:07 п.п.)
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-7015
https://issues.apache.org/jira/browse/AMBARI-7015
Repository: ambari
Description
-------
When the API client makes a call to save multiple configs for a service in batch, the server ends up creating multiple SCVs. This should result in only one SCV.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java c465189
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java 14cc6be
ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java f3668c1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java a881730
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b0e2dd4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 559f64d
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8970961
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 1161cc6
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java ee6952a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 4d68402
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 847a34d
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java ca76dc5
ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java e13c25e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 7d51184
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 94bd0c2
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java ffd4358
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 222924b
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java e794e01
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java c0bdaa2
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java f8d16c8
Diff: https://reviews.apache.org/r/25063/diff/
Testing (updated)
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [5.254s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.305s]
[INFO] Ambari Web ........................................ SUCCESS [30.446s]
[INFO] Ambari Views ...................................... SUCCESS [2.000s]
[INFO] Ambari Admin View ................................. SUCCESS [32.327s]
[INFO] Ambari Server ..................................... SUCCESS [18:09.137s]
[INFO] Ambari Agent ...................................... SUCCESS [6.148s]
[INFO] Ambari Client ..................................... SUCCESS [0.089s]
[INFO] Ambari Python Client .............................. SUCCESS [0.518s]
[INFO] Ambari Groovy Client .............................. SUCCESS [9.430s]
[INFO] Ambari Shell ...................................... SUCCESS [0.048s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.128s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [5.654s]
Thanks,
Dmytro Sen