You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "tonghuaroot (via GitHub)" <gi...@apache.org> on 2026/06/10 03:48:29 UTC
[PR] [SPARK-57363][PS][TESTS] Add tests for Index.identical in pandas-on-Spark [spark]
tonghuaroot opened a new pull request, #56423:
URL: https://github.com/apache/spark/pull/56423
### What changes were proposed in this pull request?
This PR adds positive parity tests for `Index.identical` in pandas-on-Spark
(`IndexBasicMixin` in `python/pyspark/pandas/tests/indexes/test_basic.py`).
The tests compare the `True`/`False` result of `Index.identical` against
pandas for single `Index` and `MultiIndex`: equal elements with the same
name, equal elements with a different name (the case that distinguishes
`identical` from `equals`), unequal elements, and comparing an `Index`
against a `MultiIndex`.
### Why are the changes needed?
`Index.identical` currently has no positive test coverage. The only mention
of it in the test suite is a comment in `test_equals` noting that `equals`
ignores the index name unlike `identical`; the method itself is never
exercised. These tests close that gap and lock in that `identical` returns
`True` only when both the elements and the name match.
### Does this PR introduce _any_ user-facing change?
No. This PR only adds tests.
### How was this patch tested?
Ran the new test against a local SparkSession
(`IndexBasicTests.test_identical`); it passes.
### Was this patch authored or co-authored using generative AI tooling?
Yes, this patch was co-authored with generative AI tooling (Claude,
Anthropic Opus 4.8). The contributor selected the under-tested method,
required that the asserted cases first be verified to match pandas on a
real SparkSession (excluding inputs where pandas-on-Spark intentionally
differs, e.g. NaN comparison under Spark equality), and reviewed the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57363][PS][TESTS] Add tests for Index.identical in pandas-on-Spark [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56423:
URL: https://github.com/apache/spark/pull/56423#issuecomment-5861409506
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57363][PS][TESTS] Add tests for Index.identical in pandas-on-Spark [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #56423: [SPARK-57363][PS][TESTS] Add tests for Index.identical in pandas-on-Spark
URL: https://github.com/apache/spark/pull/56423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org