[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4892: /cdns/capacity returns 500 error: capacity was zero

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #4892:
URL: https://github.com/apache/trafficcontrol/pull/4892#discussion_r458914717



##########
File path: CHANGELOG.md
##########
@@ -28,6 +28,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Updated /deliveryservices/{{ID}}/servers/eligible to use multiple interfaces in API v3
 
 ### Fixed
+- Fixed #4848 - `GET /api/x/cdns/capacity` gives back 500, with the message `capacity was zero`. [Related github issue](https://github.com/apache/trafficcontrol/issues/4848)

Review comment:
       This is a nitpick, but you should link the actual issue text to the issue instead of adding it as post-text when the issue in question was mentioned (and, if viewed in Github, actually linked) earlier:
   
   ```markdown
   - Fixed [#4848](https://github.com/apache/trafficcontrol/issues/4848) - `GET /api/x/cdns/capacity` gives back 500, with the message `capacity was zero`.
   ```
   
   but since the changelog is primarily found on GitHub, you really don't need to explicitly link at all if you don't want to, like the entry directly below yours.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org